Conversation
Add LoopbackEvent::ToolStart emitted before tool execution and extend LoopbackEvent::ToolOutput with tool_call_id and is_error fields. UUIDs are generated per tool invocation and threaded through the pipeline. ACP agent now emits SessionUpdate::ToolCall(InProgress) before execution and SessionUpdate::ToolCallUpdate(Completed|Failed) with content after, correcting the previous behavior of emitting a single Completed event. Add configurable terminal command timeout (default 120s) to AcpShellExecutor. On timeout: kill_terminal_command is called, partial output is collected, and AcpError::TerminalTimeout is returned. Closes #926 (G5, G6)
Document G5 two-step tool call lifecycle (InProgress/Completed) and G6 terminal command timeout in advanced/acp.md, advanced/tools.md, and the zeph-acp/zeph-core crate READMEs. Add terminal_timeout_secs to configuration table and add ACP Tool Notifications section to tools.md explaining UUID correlation and tool kind mapping.
github-actions
bot
added
documentation
…riant Add tool_call_id and is_error params to AppChannel::send_tool_output, add ToolStart arm to daemon.rs match to fix non-exhaustive pattern error. Resolve merge conflicts in zeph-acp README and docs/advanced/acp.md, preserving both G5/G6 changes and upstream protocol docs additions.
This was
linked to
issues
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SessionUpdate::ToolCall(InProgress)is emitted before tool execution;SessionUpdate::ToolCallUpdate(Completed|Failed)with content is emitted after. Each tool call is identified by a UUID threaded throughLoopbackEvent::ToolStartandLoopbackEvent::ToolOutput.AcpShellExecutorenforces a configurable wall-clock timeout (default 120 s) on IDE-proxied shell commands. On expiry:kill_terminal_commandis called, partial output is returned, andAcpError::TerminalTimeoutis propagated to the agent loop.Changes
zeph-corechannel.rsLoopbackEvent::ToolStart; extendLoopbackEvent::ToolOutputwithtool_call_idandis_error; addChannel::send_tool_startzeph-coreagent/tool_execution.rssend_tool_startper tool; threadtool_call_id/is_errorintosend_tool_outputzeph-acpagent.rsloopback_event_to_updatereturnsVec<SessionUpdate>; mapsToolStart→ToolCall(InProgress),ToolOutput→ `ToolCallUpdate(Completedzeph-acpterminal.rstimeout_secsfield; wrapwait_for_terminal_exitintokio::time::timeout; callkill_terminal_commandon expiryzeph-acperror.rsTerminalTimeout { output }variantzeph-channelsany.rssend_tool_outputsignaturezeph-tuichannel.rssend_tool_outputsignatureTest plan
cargo nextest run --workspace --lib --bins)cargo clippy --workspace -- -D warnings— zero warningscargo +nightly fmt --check— clean