Skip to content

ci(zeph-acp): add CI guard against AcpPermissionGate::new(_, None) reintroduction#6524

Merged
bug-ops merged 1 commit into
mainfrom
fix/6515-zeph-acp-ci-lint-guard
Jul 19, 2026
Merged

ci(zeph-acp): add CI guard against AcpPermissionGate::new(_, None) reintroduction#6524
bug-ops merged 1 commit into
mainfrom
fix/6515-zeph-acp-ci-lint-guard

Conversation

@bug-ops

@bug-ops bug-ops commented Jul 19, 2026

Copy link
Copy Markdown
Owner

Summary

Test plan

  • bash .github/scripts/check_acp_permission_gate.sh passes on the current tree (exit 0).
  • Manually verified detection: reintroducing None at multiple sites (including both halves of the two multi-gate isolation tests) is correctly flagged with file:line and a fix hint; reverting restores a clean pass.
  • Verified the guard passes under real GNU grep (Linux CI base image, rust:1.97.1-slim container), not just BSD/macOS grep — an earlier revision had a GNU-grep-only self-test failure caught and fixed here (-H flag).
  • shellcheck clean on the new script.
  • cargo nextest -p zeph-acp --features zeph-core/scheduler: 131/131 passed.
  • cargo +nightly fmt --check clean.
  • gitleaks protect --staged clean.

Closes #6515

…introduction

A None second argument falls back to the developer's real acp-permissions.toml
instead of an isolated test path, silently persisting AllowAlways/RejectAlways
decisions across unrelated test runs (#6512, fixed for both terminal.rs and
permission.rs by PR #6514). Adds a self-testing bash guard,
check_acp_permission_gate.sh, wired into the lint-shellcheck CI job, that fails
the build if the pattern reappears in crates/zeph-acp/src.

Closes #6515
@github-actions github-actions Bot added documentation Improvements or additions to documentation ci CI/CD configuration size/M Medium PR (51-200 lines) labels Jul 19, 2026
@bug-ops
bug-ops enabled auto-merge (squash) July 19, 2026 23:01
@bug-ops
bug-ops merged commit deb9364 into main Jul 19, 2026
43 checks passed
@bug-ops
bug-ops deleted the fix/6515-zeph-acp-ci-lint-guard branch July 19, 2026 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci CI/CD configuration documentation Improvements or additions to documentation size/M Medium PR (51-200 lines)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

zeph-acp: add CI/lint guard against reintroducing AcpPermissionGate::new(_, None) in tests

1 participant