perf: minify widget.js + lodash-es tree-shaking#554
Open
Conversation
📦 TestPyPI package publishedpip install --index-strategy unsafe-best-match --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ buckaroo==0.12.9.dev22336076976or with uv: uv pip install --index-strategy unsafe-best-match --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ buckaroo==0.12.9.dev22336076976MCP server for Claude Codeclaude mcp add buckaroo-table -- uvx --from "buckaroo[mcp]==0.12.9.dev22336076976" --index-strategy unsafe-best-match --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ buckaroo-table |
Add --minify and --sourcemap flags to the widget.js build command. widget.js drops from 3.5 MB to 1.8 MB. standalone.js also gets --sourcemap. Add *.js.map to .gitignore for the new sourcemaps. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Bump all @ag-grid-community/* packages from ^32.3.3 to ^32.3.9 to pick up bug fixes before the v33 migration. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace lodash (CJS) with lodash-es (ESM) as a runtime dependency. lodash-es allows bundlers (vite, esbuild) to tree-shake unused functions. Keep lodash in devDependencies for Jest (mapped via moduleNameMapper). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace `import * as _ from "lodash-es"` with named imports like
`import { map, filter, keys } from "lodash-es"` across all files.
Remove unused lodash imports from 10 files that didn't use any
lodash functions. This ensures all bundlers (including esbuild)
can tree-shake unused lodash functions.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
paddymul
force-pushed
the
perf/minify-bundle
branch
from
81cd3c9 to
c5aa25f
Compare
- deploy-ghpage.yml and publish-storybook.yml: replace run_install: true with explicit pnpm install --frozen-lockfile from packages/ working directory (matches checks.yml pattern) - All three workflows: change pull_request branches filter from "*" to "**" so CI runs on PRs targeting branches with "/" Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--minify --sourcemapto widget.js esbuild (3.5 MB → 1.8 MB)lodash→lodash-esfor ESM tree-shakingTest plan
tsc -b— 0 errorspnpm test— 67/67 passfull_build.sh— widget.js 1.8 MB (was 3.5 MB)🤖 Generated with Claude Code