fix: type error when constructing RepublicError on error#167
Merged
frostming merged 1 commit intobubbuild:mainfrom Apr 13, 2026
Merged
fix: type error when constructing RepublicError on error#167frostming merged 1 commit intobubbuild:mainfrom
frostming merged 1 commit intobubbuild:mainfrom
Conversation
frostming
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bub won't report the error message on error, the stack trace:
The reason is that the exception instance was created with "kind" using the wrong type, a str instead of the enum.
This PR fixes this issue by updating the construction statement for the RepublicError type when an error occurs. Another possible solution would be to modify the RepublicError type to accept a raw string type for the "kind" field and do the type conversion inside. Please let me know if this makes more sense.