chore: adopt @btravstack config 0.2.x#25
Merged
Conversation
- Bump @btravstack/tsconfig 0.1.0->0.2.0, @btravstack/oxlint 0.1.0->0.2.1 - Add @btravstack/lefthook 0.1.1 (shared pre-commit/commit-msg hooks) - lefthook.yml now extends the shared config, keeping local format/lint excludes - tsconfig 0.2.0 drops "types": ["node"] from the base and enables verbatimModuleSyntax; add "types": ["node"] per consuming tsconfig for node globals, and oxlint --fix adds type-only import specifiers in bootstrap.ts - knip: ignore @btravstack/lefthook (config-only dep)
There was a problem hiding this comment.
Pull request overview
Adopts updated @btravstack shared tooling/config packages (tsconfig/oxlint/lefthook) and performs the required TypeScript migrations for @btravstack/tsconfig@0.2.0 (notably verbatimModuleSyntax and loss of implicit Node types).
Changes:
- Bumps the pnpm catalog versions for
@btravstack/tsconfigand@btravstack/oxlint, and adds@btravstack/lefthook(plus release-age exclusion). - Switches local
lefthook.ymlto extend the shared@btravstack/lefthookconfig while preserving repo-specific excludes. - Updates package/example
tsconfig.jsonfiles to explicitly include Node types; updates example bootstraps to use type-only imports where appropriate underverbatimModuleSyntax.
Reviewed changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml | Updates catalog versions and adds @btravstack/lefthook (and excludes it from minimum release age). |
| pnpm-lock.yaml | Lockfile updates reflecting the catalog bumps and new shared lefthook config package. |
| package.json | Adds @btravstack/lefthook as a devDependency via catalog:. |
| lefthook.yml | Extends shared lefthook config and keeps local exclude patterns for format/lint. |
| knip.json | Ignores @btravstack/lefthook as a config-only dependency. |
| packages/start-temporal/tsconfig.json | Explicitly adds types: ["node"] after tsconfig base change. |
| packages/start-kernel/tsconfig.json | Explicitly adds types: ["node"] after tsconfig base change. |
| packages/start-api/tsconfig.json | Explicitly adds types: ["node"] after tsconfig base change. |
| packages/start-amqp/tsconfig.json | Explicitly adds types: ["node"] after tsconfig base change. |
| examples/start-temporal-worker/tsconfig.json | Explicitly adds types: ["node"] after tsconfig base change. |
| examples/start-temporal-worker/src/bootstrap.ts | Uses type-only import for Payments to satisfy verbatimModuleSyntax. |
| examples/start-orpc-prisma/tsconfig.json | Explicitly adds types: ["node"] after tsconfig base change. |
| examples/start-orpc-prisma/src/bootstrap.ts | Uses type-only import for TodoRepository to satisfy verbatimModuleSyntax. |
| examples/start-api-todo/tsconfig.json | Explicitly adds types: ["node"] after tsconfig base change. |
| examples/start-api-todo/src/bootstrap.ts | Uses type-only import for TodoRepository to satisfy verbatimModuleSyntax. |
| examples/start-amqp-worker/tsconfig.json | Explicitly adds types: ["node"] after tsconfig base change. |
| examples/start-amqp-worker/src/bootstrap.ts | Uses type-only import for Payments to satisfy verbatimModuleSyntax. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts the latest
@btravstackshared config (tools-removal already merged to main).Changes
pnpm-workspace.yaml):@btravstack/tsconfig0.1.0 → 0.2.0,@btravstack/oxlint0.1.0 → 0.2.1; add@btravstack/lefthook0.1.1. Added@btravstack/lefthooktominimumReleaseAgeExclude.package.json: add@btravstack/lefthookdevDep (catalog:).lefthook.yml: nowextendsthe shared@btravstack/lefthook/lefthook.yml(format + lint + commit-msg), keeping the localformatexcludes (pnpm-lock.yaml,packages/*/docs/**) andlintexclude (*.test-d.ts).knip.json: ignore@btravstack/lefthook(config-only dependency).Follow-on from tsconfig 0.2.0
tsconfig 0.2.0 drops
"types": ["node"]frombase.jsonand enablesverbatimModuleSyntax. Required migration:"types": ["node"]to each consuming tsconfig (4 packages + 4 examples) so Node globals (console,fetch,Response,crypto) resolve — auto-inclusion of@types/*does not pick them up under pnpm's symlinked layout with TS 6.0.3.oxlint . --fixadded type-only import specifiers (import { type ... }) in the fourbootstrap.tsfiles, required now thatverbatimModuleSyntaxno longer elides type-only imports.Gate (all green)
pnpm build✅ (5/5 tasks)pnpm typecheck✅ (13/13)pnpm lint✅pnpm format --check✅pnpm knip✅pnpm audit --audit-level=high✅ (2 moderate, below threshold)pnpm test✅ (13/13, unit tests; integrationtest:integrationnot run — needs testcontainers/docker)changeset status --since=origin/main✅ exit 0 — no changeset needed (all changed packages are private and covered by the existingignoreglobs)