fix(color): don't throw on empty computed color - #268
Open
Aaryan430 wants to merge 1 commit into
Open
Conversation
A detached/inert node (mutation re-scan, or a <template>/shadow subtree) yields an empty computed *-color. colorjs throws "Empty color reference" on it, and that uncaught abort takes down the whole in-page Type-B data collection (and cascades to subsequent Workflow-Analyser steps). Guard parseString: treat a blank/non-string value as transparent instead of throwing. Genuinely-transparent colors (rgba(0,0,0,0)) still parse normally; only empty (== a non-rendered node) is short-circuited, so no element that a rule actually scores changes verdict. Adds parseString specs for empty / whitespace / non-string input. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
sunny-se
approved these changes
Jul 29, 2026
Aaryan430
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.