Skip to content

[meta] do not publish .claude#342

Closed
Avicennasis wants to merge 1 commit into
browserify:mainfrom
Avicennasis:issue341
Closed

[meta] do not publish .claude#342
Avicennasis wants to merge 1 commit into
browserify:mainfrom
Avicennasis:issue341

Conversation

@Avicennasis

Copy link
Copy Markdown

Adds .claude to publishConfig.ignore, following the same approach as 816c9e2 for .gitmodules.

As noted in #338 and #341, resolve@1.22.12 ships .claude/settings.local.json and .claude/notes.md in the published tarball. In #341 you mentioned that explicitly adding .claude to .npmignore would be a viable solution — since .npmignore here is generated by npmignore --auto from publishConfig.ignore, this adds it there.

2.0.0-next.7 happens to be clean, so this is purely defensive for future publishes (and would cover the 1.x line if backported).

Verified locally: planted a dummy .claude/settings.local.json in the working tree; with this change, npm pack --dry-run (via the prepack npmignore step) excludes it.

Refs #338. Refs #341.

@ljharb

ljharb commented Jul 2, 2026

Copy link
Copy Markdown
Member

there's no need for this; i added a feature to npm itself so it can be globally npmignored, and there's no danger of publishing .claude files anyways.

@ljharb ljharb closed this Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants