[meta] do not publish .claude#342
Closed
Avicennasis wants to merge 1 commit into
Closed
Conversation
Member
|
there's no need for this; i added a feature to npm itself so it can be globally npmignored, and there's no danger of publishing .claude files anyways. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
.claudetopublishConfig.ignore, following the same approach as 816c9e2 for.gitmodules.As noted in #338 and #341,
resolve@1.22.12ships.claude/settings.local.jsonand.claude/notes.mdin the published tarball. In #341 you mentioned that explicitly adding.claudeto.npmignorewould be a viable solution — since.npmignorehere is generated bynpmignore --autofrompublishConfig.ignore, this adds it there.2.0.0-next.7happens to be clean, so this is purely defensive for future publishes (and would cover the 1.x line if backported).Verified locally: planted a dummy
.claude/settings.local.jsonin the working tree; with this change,npm pack --dry-run(via theprepacknpmignore step) excludes it.Refs #338. Refs #341.