simplify order.Which so type is always seralized as string#6823
Merged
simplify order.Which so type is always seralized as string#6823
Conversation
nwt
approved these changes
Apr 13, 2026
order/direction.go
Outdated
Comment on lines
+33
to
+39
| func (d Direction) Which() Which { | ||
| if d == Down { | ||
| return Desc | ||
| } | ||
| return Asc | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
As I mentioned here, implicit conversion from Unknown to Asc feels like a potential rake, so maybe add a comment or a default parameter?
mattnibs
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.