Skip to content

Fix empty logs#400

Merged
brickbots merged 8 commits intomainfrom
fix-empty-log
Apr 7, 2026
Merged

Fix empty logs#400
brickbots merged 8 commits intomainfrom
fix-empty-log

Conversation

@jscheidtmann
Copy link
Copy Markdown
Collaborator

@jscheidtmann jscheidtmann commented Mar 20, 2026

Some logs didn't get stored in the log file, due to an issue with Multiproc logger.

Along the way:

  • Silence warnings in VScode, that are catched by nox.
    • ruff complaining about _ not being defined.
    • flagging of comments in json
    • pylance also complaining about _
  • Fix an exception in comet processing
  • Using a dynamic path to the PiFinder_data directory, so the log tab in the website is able to read the current log file.

TODOs:

  • Test on physical PiFinder unit.

Stack generated by Git Town

@jscheidtmann jscheidtmann marked this pull request as draft March 20, 2026 07:22
@jscheidtmann jscheidtmann requested a review from brickbots March 31, 2026 07:01
@jscheidtmann jscheidtmann marked this pull request as ready for review April 6, 2026 18:30
@brickbots brickbots merged commit 900a743 into main Apr 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants