Harden generated media tags and batch tag merge#19
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bf4ec6fa1d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| else: | ||
| merged[filepath]['results'].append(result) |
There was a problem hiding this comment.
Preserve query order when merging duplicate result tags
The new tag merge path appends duplicate hits in whatever order all_results is iterated, but all_results is populated via as_completed, so completion timing can reorder queries between runs. In batches where multiple queries hit the same filepath with different tags, tags=_merge_tags(data['results']) will produce different tag orders for identical inputs, which breaks reproducibility and can make deterministic-order assertions flaky.
Useful? React with 👍 / 👎.
Summary
Testing
Closes REC-192
Closes REC-193