Skip to content

fix: validate Buffer type in PutCopyData before calling Buffer::Data #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MinhyukHong wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: validate Buffer type in PutCopyData before calling Buffer::Data #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8970115
Update connection.cc
MinhyukHong May 7, 2026
891616c
Fix missing closing parenthesis in buffer check
MinhyukHong May 8, 2026
469ce9f
Add TypeError test for putCopyData method
MinhyukHong May 8, 2026
4490844
Fix typo in test description for data assumptions
MinhyukHong May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/connection.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,6 +656,10 @@ NAN_METHOD(Connection::PutCopyData) {

Connection* self = NODE_THIS();

if (!node::Buffer::HasInstance(info[0])) {
return Nan::ThrowTypeError("First argument must be a Buffer");
}

v8::Local<v8::Object> buffer = info[0].As<v8::Object>();

char* data = node::Buffer::Data(buffer);
Expand Down
10 changes: 9 additions & 1 deletion test/copy-in.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ var bufferFrom = require('buffer-from')
describe('COPY IN', function() {
helper.setupIntegration();

it('check existing data assuptions', function() {
it('check existing data assumptions', function() {
this.pq.exec('SELECT COUNT(*) FROM test_data');
assert.equal(this.pq.getvalue(0, 0), 3);
});
Expand Down Expand Up @@ -45,4 +45,12 @@ describe('COPY IN', function() {
this.pq.exec('SELECT COUNT(*) FROM test_data');
assert.equal(this.pq.getvalue(0, 0), 4);
});

it('throws TypeError when non-Buffer is passed to putCopyData', function() {
assert.throws(function() {
this.pq.$putCopyData("not a buffer");
}.bind(this), function(err) {
return err instanceof TypeError;
});
});
});