Brev 9311/fix invalid instance type error#386
Open
arush070 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
brev create --type <x>printed the backend's internal messagecloudCredId or workspaceGroupId must be specifiedwhenever:Change
Two-layer validation, both in CLI code (no parsing of backend strings):
createInstancesWithTypevalidateInstanceTypeAvailability(spec.Type)returnsbreverrors.ValidationErrorwith one of:instance type "<x>" is not a recognized type; run 'brev search' to see available typesinstance type "<x>" is currently unavailable (no capacity); try again later or run 'brev search' to find another typeSkipping: <message>so the user sees the type once.--launchable(launchables supply their own workspace group and may reference types outside the org listing).createWorkspacecwOptions.WorkspaceGroupID == ""after all resolution paths (instance-type lookup, launchable config), return aValidationErrorbefore the API call. Separate message when the listing API itself was unavailable, so the user can retry vs. fixthe type.
AllInstanceTypesResponse.HasInstanceTypeinpkg/cmd/gpusearch/gpusearch.goso the validation can tell "unknown" from "known but no groups".Tests
New cases:
TestValidateInstanceTypeAvailability(5 subtests: nil listing, valid group, unknown type, known-but-no-groups, error isValidationError)TestCreateInstancesWithTypeSkipsInvalidTypeTestCreateInstancesWithTypeSkipsUnavailableTypeTestCreateInstancesWithTypeBypassesValidationForLaunchableTestAllInstanceTypesResponseLookup(5 subtests forGetWorkspaceGroupID+HasInstanceType)