MNT: move cibw's configuration to TOML#159
Conversation
| uses: pypa/cibuildwheel@v3.3.1 | ||
| env: | ||
| # if adding python 3.15, just add cp315-* | ||
| CIBW_BUILD: "cp310-* cp311-* cp312-* cp313-* cp314-*" |
There was a problem hiding this comment.
I intentionally didn't reproduce this line verbatim because cibw's already parses project.requires-python from pyproject.toml, and set the appropriate upper bound itself.
neutrinoceros
force-pushed
the
mnt/static-cibw-conf
branch
2 times, most recently
from
79c19d1 to
5aa8436
Compare
| [tool.cibuildwheel] | ||
| build-verbosity = 0 | ||
| skip = [ | ||
| "*-musllinux_*", # not sure there's a good reason for this anymore ? |
There was a problem hiding this comment.
very likely this was done because numpy didn't serve this target at the time, but it does now, so maybe we can re-enable it here or in a follow up PR ?
There was a problem hiding this comment.
Yes, let's save that for a future PR. Thanks for pointing it out; in the original commit that added it, I don't see a comment from the contributor explaining why, so we're left with the guess that it was NumPy.
| build-verbosity = 0 | ||
| skip = [ | ||
| "*-musllinux_*", # not sure there's a good reason for this anymore ? | ||
| "cp314t-*", |
There was a problem hiding this comment.
recent versions of cibw include Free-threading 3.14 (3.14t) by default (though, not 3.13t). I assume we don't want to add it here.
FWIW it might get significantly easier to serve both builds (3.1x and 3.1xt) with a single wheel per platform in the near future, provided PEP 803 is accepted for Python 3.15
There was a problem hiding this comment.
I agree that this would not be the PR for introducing a free-threading build, and that it might be useful to hold off and see what happens with PEP 803. I'll have to go read it sometime. Thanks!
There was a problem hiding this comment.
PEP 803 is now accepted and implementation is expected to land in 3.15.0b1, FYI
neutrinoceros
force-pushed
the
mnt/static-cibw-conf
branch
3 times, most recently
from
dabd17c to
4541eb0
Compare
neutrinoceros
changed the title
neutrinoceros
force-pushed
the
mnt/static-cibw-conf
branch
2 times, most recently
from
542618c to
74639d1
Compare
neutrinoceros
force-pushed
the
mnt/static-cibw-conf
branch
from
74639d1 to
9c47a28
Compare
neutrinoceros
changed the title
|
I like how this pulls project data out of a proprietary CI YAML file, and into the main project configuration. Thanks for working on it! |
2 participants
Based off #155 which introduced
pyproject.tomlIncidentally also includes #153