RFC: treat PyTypeObject as an opaque struct for Limited API compliance#157
Draft
neutrinoceros wants to merge 2 commits intobrandon-rhodes:masterfrom
Draft
RFC: treat PyTypeObject as an opaque struct for Limited API compliance#157neutrinoceros wants to merge 2 commits intobrandon-rhodes:masterfrom
PyTypeObject as an opaque struct for Limited API compliance#157neutrinoceros wants to merge 2 commits intobrandon-rhodes:masterfrom
Conversation
Author
|
The only difference I can see between this broken code and the known-working examples I have in astropy is that this module is C++ while the ones I can compile are C... if that's the meaningful difference I may be out of my depth, as I cannot think of a single reason why that would matter. |
7f37a8f to
a43ed6c
Compare
Author
|
found inspiration from this stack overflow thread. It compiles okay if I use type casting. Maybe C compilers just do the exact same thing implicitly and I never knew it was needed ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needed for #151
based off #153
This one doesn't compile yet, but the good news is that the errors are identical wether I force abi3 or not.