RFC: redefine PyTypeObjects as heap types for Limited API compliance#154
Draft
neutrinoceros wants to merge 2 commits intobrandon-rhodes:masterfrom
Draft
RFC: redefine PyTypeObjects as heap types for Limited API compliance#154neutrinoceros wants to merge 2 commits intobrandon-rhodes:masterfrom
neutrinoceros wants to merge 2 commits intobrandon-rhodes:masterfrom
Conversation
Author
|
maybe the rabbit hole goes a lot deeper. I think this is just the first symptom of a much broader issue: |
Author
|
FWIW I doubt that this change can be handled simply without dropping Python 2.7 too, but I also don't have a simple way to check. |
Author
|
... which might not be a problem since, IIUC, the extension is only ever compiled for Python 3 anyway |
7124b3e to
dc0a5ac
Compare
Author
|
I got it to compile locally. Hopefully it runs smoothly in CI too. |
dc0a5ac to
d96ef3f
Compare
This was referenced Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based off #153
needed for #151
At the time of opening, I'm getting a single compilation error:
I don't have experience with "sub slots", which seem needed for defining the
tp_as_sequenceslot correctly. Hopefully I can crack it soon but in the mean time, any help would be appreciated.