Do not destroy and create new player on video change.#48
Open
qubird wants to merge 1 commit intobrandly:masterfrom
Open
Do not destroy and create new player on video change.#48qubird wants to merge 1 commit intobrandly:masterfrom
qubird wants to merge 1 commit intobrandly:masterfrom
Conversation
Fix for brandly#46. Instead of creating a new player, use the current one when it's already existing, loading the new video via YT method loadVideoById
|
I have experienced this same problem. I didn't know what scope.player.d was, but I didn't want to remove that code in case it was doing something. So I decided that when the player was created I would fill it with something that would allow the check to destroy it in the even that it never gets overwritten or filled with something else. I added this:
x Jeremy M. Directive portion in the function: createPlayer
P.S. - I am sorry is this is a newbie way to respond, but I just signed into git hub in order to post this, and so I am indeed a newbie. Hope this helps. |
alexthewilde
added a commit
to alexthewilde/angular-youtube-embed
that referenced
this pull request
Jul 16, 2015
See original issue brandly#46 Fix adapted from brandly#48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #46.
Instead of creating a new player, use the current one when it's already existing, loading the new video via YT method loadVideoById