Skip to content

google_genai and pydantic init_logger no longer unconditionally called during auto_instrument #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ViaDézo1er / cedric (viadezo1er) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

google_genai and pydantic init_logger no longer unconditionally called during auto_instrument #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions py/src/braintrust/integrations/adk/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import logging
import warnings

from braintrust.logger import NOOP_SPAN, current_span, init_logger
from braintrust.logger import NOOP_SPAN, current_logger, current_span, init_logger

from .integration import ADKIntegration
from .patchers import (
Expand Down Expand Up @@ -56,7 +56,7 @@ def setup_adk(
warnings.warn("SpanProcessor parameter is deprecated and will be ignored", DeprecationWarning, stacklevel=2)

span = current_span()
if span == NOOP_SPAN:
if span == NOOP_SPAN and current_logger() is None:
init_logger(project=project_name, api_key=api_key, project_id=project_id)

return ADKIntegration.setup()
4 changes: 2 additions & 2 deletions py/src/braintrust/integrations/agno/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import logging

from braintrust.logger import NOOP_SPAN, current_span, init_logger
from braintrust.logger import NOOP_SPAN, current_logger, current_span, init_logger

from .integration import AgnoIntegration
from .patchers import (
Expand Down Expand Up @@ -44,7 +44,7 @@ def setup_agno(
True if setup was successful, False otherwise
"""
span = current_span()
if span == NOOP_SPAN:
if span == NOOP_SPAN and current_logger() is None:
init_logger(project=project_name, api_key=api_key, project_id=project_id)

return AgnoIntegration.setup()
4 changes: 2 additions & 2 deletions py/src/braintrust/integrations/claude_agent_sdk/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

import logging

from braintrust.logger import NOOP_SPAN, current_span, init_logger
from braintrust.logger import NOOP_SPAN, current_logger, current_span, init_logger

from .integration import ClaudeAgentSDKIntegration

Expand Down Expand Up @@ -58,7 +58,7 @@ def setup_claude_agent_sdk(
```
"""
span = current_span()
if span == NOOP_SPAN:
if span == NOOP_SPAN and current_logger() is None:
init_logger(project=project, api_key=api_key, project_id=project_id)

return ClaudeAgentSDKIntegration.setup()
4 changes: 2 additions & 2 deletions py/src/braintrust/integrations/google_genai/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import logging

from braintrust.logger import NOOP_SPAN, current_span, init_logger
from braintrust.logger import NOOP_SPAN, current_logger, current_span, init_logger

from .integration import GoogleGenAIIntegration

Expand Down Expand Up @@ -33,7 +33,7 @@ def setup_genai(
True if setup was successful, False if google-genai is not installed.
"""
span = current_span()
if span == NOOP_SPAN:
if span == NOOP_SPAN and current_logger() is None:
init_logger(project=project_name, api_key=api_key, project_id=project_id)

return GoogleGenAIIntegration.setup()
4 changes: 2 additions & 2 deletions py/src/braintrust/wrappers/pydantic_ai.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from typing import Any

from braintrust.bt_json import bt_safe_deep_copy
from braintrust.logger import NOOP_SPAN, Attachment, current_span, init_logger, start_span
from braintrust.logger import NOOP_SPAN, Attachment, current_logger, current_span, init_logger, start_span
from braintrust.span_types import SpanTypeAttribute
from wrapt import wrap_function_wrapper

Expand All @@ -34,7 +34,7 @@ def setup_pydantic_ai(
bool: True if setup was successful, False otherwise.
"""
span = current_span()
if span == NOOP_SPAN:
if span == NOOP_SPAN and current_logger() is None:
init_logger(project=project_name, api_key=api_key, project_id=project_id)

try:
Expand Down
Loading