Fix Google GenAI input serialization for Content objects and tool fallback#167
Open
colinbennettbrain wants to merge 3 commits intomainfrom
Open
Fix Google GenAI input serialization for Content objects and tool fallback#167colinbennettbrain wants to merge 3 commits intomainfrom
colinbennettbrain wants to merge 3 commits intomainfrom
Conversation
There was a problem hiding this comment.
let’s avoid tests with mocks and use vcr based cassette tests instead.
I have to improve the agent skills so that this becomes the default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes contents serialization for types. Content objects by recursively serializing nested parts, so binary Part.inline_data inside Content.parts is preserved as Braintrust attachments instead of falling through generic serialization. It also hardens tool serialization by keeping Google’s serializer as the primary path, but adding debug logging and a best-effort fallback when that path fails, so tool definitions are still logged in structured form rather than being silently dropped.
The change includes regression tests covering nested binary content serialization and tool fallback behavior.