Add azure entra oidc schema for secrets#661
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 61b79f2677
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| .enum(["api_key", "entra_api", "entra_oidc", "entra_bearer"]) | ||
| .default("api_key"), |
There was a problem hiding this comment.
Allowing entra_oidc and entra_bearer here makes config validation succeed even though request execution only implements entra_api (packages/proxy/src/proxy.ts only branches on auth_type === "entra_api" around lines 2235-2258). For entra_oidc, users are expected to store structured JSON (per the new OIDC schema), but the fallback path treats secret.secret as a raw bearer token and then also sets api-key from that same value, producing invalid Azure auth at runtime. This is a regression introduced by broadening the enum before the corresponding auth flow is wired in.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
this is fine, this is only gonna be supported for gateway
2 participants
No description provided.