Skip to content

Emit tool approval metadata for Codex tool spans#12

Merged
Andrew Kent (realark) merged 1 commit into
mainfrom
agent/tool-outcome-metadata-codex
Jul 23, 2026
Merged

Emit tool approval metadata for Codex tool spans#12
Andrew Kent (realark) merged 1 commit into
mainfrom
agent/tool-outcome-metadata-codex

Conversation

@Qard

@Qard Stephen Belanger (Qard) commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Emit metadata.tool_approval = "approved" for completed Codex tool executions.
  • Keep failed or dangling tool spans marked by the top-level error field.
  • Update Codex tool span tests to assert approval metadata instead of success/error outcome metadata.

Validation

  • bun test plugins/trace-codex/src/agents/codex/event-processor.test.ts
  • bun run typecheck (from plugins/trace-codex)
  • bun run check (from plugins/trace-codex)

@Qard
Stephen Belanger (Qard) force-pushed the agent/tool-outcome-metadata-codex branch from 09a3507 to 53d5ef5 Compare July 20, 2026 14:52
@Qard Stephen Belanger (Qard) changed the title Emit tool outcome metadata for Codex tool spans Emit tool approval metadata for Codex tool spans Jul 20, 2026
@realark
Andrew Kent (realark) merged commit a4ff01f into main Jul 23, 2026
4 checks passed
@realark
Andrew Kent (realark) deleted the agent/tool-outcome-metadata-codex branch July 23, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants