Fix size() used as loop bound in parameter parsing - #1
Open
jindonut wants to merge 1 commit into
Open
Conversation
size() with no dimension argument returns a dimension vector, which is invalid as a colon operand. Replaced with numel() in four locations: parse_mappers.m line 3, run_main.m lines 213 and 253, run_preprocess.m line 50.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
size(x)called without a dimension argument returns a dimension vector ratherthan a scalar. Used as a colon operand in
for i = 1:size(x), this errors underR2026a: "Colon operands must be real scalars."
Replaced with
numel()in four places:numel()returns the total element count as a scalar, which is the intendedloop bound in each case.
Found all four occurrences by regex; no others exist in code/: