Skip to content

bs #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brahmscode wants to merge 9 commits into
base: main
Choose a base branch
from
Open

bs #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
21dc4fe
bs
brahmmaeswari-mahalingam Nov 30, 2021
47c952c
Update sample.rb
brahmscode Dec 22, 2021
b7250a7
Create .reviewdog.yml
brahmscode Dec 22, 2021
0d8e438
Update sample.rb
brahmscode Dec 22, 2021
449e0bc
Merge branch 'main' into test-proj
Dec 22, 2021
72e4b42
Update .reviewdog.yml
brahmscode Dec 22, 2021
3684185
Update .reviewdog.yml
brahmscode Dec 22, 2021
da554e4
Update reviewdog-setup.yml
brahmscode Dec 22, 2021
481f70b
Update .reviewdog.yml
brahmscode Dec 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/reviewdog-setup.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ jobs:
env:
REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
reviewdog -reporter=github-pr-review -runners=rubocop
reviewdog -reporter=github-pr-review -runners=golint
14 changes: 14 additions & 0 deletions .reviewdog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
runner:
# examples
golint:
cmd: golint ./...
errorformat:
- "%f:%l:%c: %m"
level: warning
govet:
cmd: go vet -all .
format: govet
your-awesome-linter:
cmd: awesome-linter run
format: rdjson
name: AwesomeLinter
4 changes: 4 additions & 0 deletions sample.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
class Sample
def hello
puts "Hello Ruby!"
puts "brahms"
Copy link

@github-actions github-actions bot Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[rubocop] <Style/StringLiterals> reported by reviewdog 🐶
Prefer single-quoted strings when you don't need string interpolation or special symbols.

Suggested change
puts "brahms"
puts 'brahms'

puts 'jji'
end
end

# Now using above class to create objects
object = Sample. new
object.hello
puts "brhms"
puts "hhiD"
Copy link

@github-actions github-actions bot Dec 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[rubocop] <Style/StringLiterals> reported by reviewdog 🐶
Prefer single-quoted strings when you don't need string interpolation or special symbols.

Suggested change
puts "hhiD"
puts 'hhiD'

puts "sjk"
Copy link

@github-actions github-actions bot Dec 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[rubocop] <Style/StringLiterals> reported by reviewdog 🐶
Prefer single-quoted strings when you don't need string interpolation or special symbols.

Suggested change
puts "sjk"
puts 'sjk'