Skip to content

pysimlin: fix schema path (doc/ -> docs/) and add missing ModelGroup dataclass#572

Open
karlhillx wants to merge 1 commit into
bpowers:mainfrom
karlhillx:fix/pysimlin-schema-path
Open

pysimlin: fix schema path (doc/ -> docs/) and add missing ModelGroup dataclass#572
karlhillx wants to merge 1 commit into
bpowers:mainfrom
karlhillx:fix/pysimlin-schema-path

Conversation

@karlhillx
Copy link
Copy Markdown

Fixes #550 and fills the ModelGroup gap it revealed. Two changes:

  1. Fix the schema path in test_json_types.py from doc/ to docs/; activates the 4 schema-compliance tests that have been silently skipped.

  2. Add the missing ModelGroup dataclass and groups field to the Python Model class. Rust json::Model, TS JsonModel, and the JSON schema all have it; Python was the only layer missing it. groups is optional in the schema so this is backward-compatible; existing serialized data without groups still deserializes fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pysimlin: JSON schema-compliance tests silently skipped due to wrong path (doc/ vs docs/)

1 participant