pysimlin: fix schema path (doc/ -> docs/) and add missing ModelGroup dataclass#572
Open
karlhillx wants to merge 1 commit into
Open
pysimlin: fix schema path (doc/ -> docs/) and add missing ModelGroup dataclass#572karlhillx wants to merge 1 commit into
karlhillx wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #550 and fills the ModelGroup gap it revealed. Two changes:
Fix the schema path in test_json_types.py from
doc/todocs/; activates the 4 schema-compliance tests that have been silently skipped.Add the missing
ModelGroupdataclass andgroupsfield to the PythonModelclass. Rustjson::Model, TSJsonModel, and the JSON schema all have it; Python was the only layer missing it.groupsis optional in the schema so this is backward-compatible; existing serialized data without groups still deserializes fine.