fix(activity-feed-v2): cap task message textarea at 6 rows#4691
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe task message TextArea in ChangesTask message layout
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
In the task modal v2, a long message with many line breaks grew the message textarea without bound, pushing the modal footer buttons out of view.
The Blueprint
TextAreaautosize supports amaxRowscap: the field grows up to the cap and then scrolls internally. AddedmaxRows={6}to the task message field (minRows={3}unchanged). Six rows matches the effective cap on the v1 task form, which limits the same field withmax-height: 140pxinTaskForm.scss.Testing
yarn test --watchAll=false --testPathPattern="task-modal-v2"- 4 suites, 65 tests passed.@box/blueprint-weband is not observable in jsdom, so no new unit test; verified visually that the textarea stops growing at 6 rows and scrolls, keeping the footer buttons in view.Summary by CodeRabbit