Skip to content

refactor(content-uploader): hide modernized uploads manager in 5000#4679

Merged
mergify[bot] merged 3 commits into
masterfrom
decrease-timer-for-uploads-manager
Jul 9, 2026
Merged

refactor(content-uploader): hide modernized uploads manager in 5000#4679
mergify[bot] merged 3 commits into
masterfrom
decrease-timer-for-uploads-manager

Conversation

@dealwith

@dealwith dealwith commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Modernized uploads manager should be hidden in 5s instead of 8s.

Summary by CodeRabbit

  • Bug Fixes
    • Updated the modern upload panel’s auto-dismiss timing to close after 5 seconds to match the expected behavior.
  • Tests
    • Adjusted the timer-based test to reflect the new 5-second delay, ensuring panel state transitions are validated accurately.

@dealwith dealwith self-assigned this Jul 8, 2026
@dealwith
dealwith requested review from a team as code owners July 8, 2026 13:09
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d48e3e1a-48ae-4538-950c-c99164898904

📥 Commits

Reviewing files that changed from the base of the PR and between 6e8d986 and ed0ed76.

📒 Files selected for processing (2)
  • src/elements/content-uploader/ContentUploader.tsx
  • src/elements/content-uploader/__tests__/ContentUploader.test.js
🚧 Files skipped from review as they are similar to previous changes (2)
  • src/elements/content-uploader/ContentUploader.tsx
  • src/elements/content-uploader/tests/ContentUploader.test.js

Walkthrough

A dedicated 5000ms dismissal constant is added for the modernized upload manager, the dismissal timer uses it, and related Jest timer tests verify the updated boundary behavior.

Changes

Dismiss delay constant update

Layer / File(s) Summary
Add and apply new dismissal delay constant
src/elements/content-uploader/ContentUploader.tsx, src/elements/content-uploader/__tests__/ContentUploader.test.js
Introduces HIDE_MODERNIZED_UPLOAD_MANAGER_DELAY_MS at 5000ms, applies it to the modernized panel dismissal timer, and updates fake-timer assertions for the new delay.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

Suggested reviewers: jpan-box, jfox-box

Poem

I nibble at timers, hop hop hop,
Five thousand ticks, then panel stop.
The latest batch gets room to land,
Then fading starts on my command.
Squeak! The uploads close as planned.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: shortening the modernized uploads manager hide delay to 5000ms.
Description check ✅ Passed The description is concise but covers the key change and includes the repository's merge-queue note template.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch decrease-timer-for-uploads-manager

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ast-grep (0.44.1)
src/elements/content-uploader/__tests__/ContentUploader.test.js

ast-grep timed out on this file


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/elements/content-uploader/ContentUploader.tsx`:
- Line 141: The delay constant in ContentUploader has changed to 5000ms, but the
related ContentUploader.test.js still hardcodes 8000ms and asserts that value,
so update the test’s HIDE_DELAY_MS and any setTimeout expectations to match
HIDE_MODERNIZED_UPLOAD_MANAGER_DELAY_MS in ContentUploader.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a7564556-4868-4a69-989f-c76172c8ac33

📥 Commits

Reviewing files that changed from the base of the PR and between c92d563 and b5a0be9.

📒 Files selected for processing (1)
  • src/elements/content-uploader/ContentUploader.tsx

Comment thread src/elements/content-uploader/ContentUploader.tsx
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@dealwith

dealwith commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

@Mergifyio queue

@mergify

mergify Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • Entered queue2026-07-09 22:26 UTC · Rule: Automatic strict merge · triggered by @dealwith with the @mergifyio queue command
  • Checks passed · in-place
  • Merged2026-07-09 22:38 UTC · at ed0ed76d1c3c46d849ba8a619d81d3768faacb85 · squash

This pull request spent 12 minutes 11 seconds in the queue, including 11 minutes 56 seconds running CI.

Required conditions to merge
  • github-review-approved [🛡 GitHub branch protection]
  • github-review-decision = APPROVED [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Summary
    • check-neutral = Summary
    • check-skipped = Summary
  • any of [🛡 GitHub branch protection]:
    • check-success = lint_test_build
    • check-neutral = lint_test_build
    • check-skipped = lint_test_build
  • any of [🛡 GitHub branch protection]:
    • check-success = license/cla
    • check-neutral = license/cla
    • check-skipped = license/cla
  • any of [🛡 GitHub branch protection]:
    • check-success = lint_pull_request
    • check-neutral = lint_pull_request
    • check-skipped = lint_pull_request

@dealwith

dealwith commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

https://github.com/Mergifyio queue

@mergify

mergify Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

queue

☑️ Command queue ignored because it is already running from a previous command.

@mergify mergify Bot added the queued label Jul 9, 2026
@mergify
mergify Bot merged commit 89ee650 into master Jul 9, 2026
14 checks passed
@mergify
mergify Bot deleted the decrease-timer-for-uploads-manager branch July 9, 2026 22:38
@mergify mergify Bot removed the queued label Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants