Skip to content

fix(activity-feed-v2): anchor feed to sidebar to prevent page scroll #4652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 1 commit into from
Jun 25, 2026
Merged

fix(activity-feed-v2): anchor feed to sidebar to prevent page scroll #4652

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 8 additions & 14 deletions src/elements/content-sidebar/activity-feed-v2/ActivityFeedV2.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,17 @@
// CSS isolation layer for ActivityFeedV2.
// BUIE global styles (.bcs scope from base.scss) apply broad rules to native
// elements (inputs, contenteditable, buttons, links, textareas). These leak
// into Blueprint and @box/threaded-annotations components, breaking their
// styling. This file resets those rules within the v2 adapter boundary.
// Resets BUIE .bcs global styles that leak into Blueprint and
// @box/threaded-annotations components.

.bcs-NewActivityFeed {
position: absolute;
inset: 0;
display: flex;
flex-direction: column;
height: 100%;
overflow: hidden;

// `display: contents` keeps the wrapper transparent to the vendor's flex layout.
&-list {
display: contents;
}

// Forms: BUIE sets width, padding, border, box-shadow, border-radius on
// contenteditable and inputs via _forms.scss inside .bcs scope.
div[contenteditable='true'],
div[contenteditable='true']:hover,
div[contenteditable='true']:focus {
Expand All @@ -31,8 +26,6 @@
transition: none;
}

// Links: BUIE forces color and text-decoration on all <a> elements
// via _links.scss.
a {
color: inherit;
text-decoration: inherit;
Expand All @@ -42,8 +35,6 @@
text-decoration: inherit;
}

// BUIE sets pointer-events: none on <svg> inside <a> and <button>,
// which breaks Blueprint icon buttons.
a svg,
button svg {
pointer-events: auto;
Expand All @@ -54,7 +45,10 @@
}
}

// Lets inner ellipsis truncation resolve against the sidebar width.
// Containing block for the absolutely positioned .bcs-NewActivityFeed child,
// so the feed fills the sidebar even when ancestors lack a definite height
// (e.g., shared-link pages).
.bcs-NewActivityFeedContent {
position: relative;
min-width: 0;
}
Loading