Skip to content

fix(activity-feed-v2): restore sidebar content left border#4645

Merged
mergify[bot] merged 1 commit into
box:masterfrom
jackiejou:fix/activity-feed-v2-restore-sidebar-divider
Jun 23, 2026
Merged

fix(activity-feed-v2): restore sidebar content left border#4645
mergify[bot] merged 1 commit into
box:masterfrom
jackiejou:fix/activity-feed-v2-restore-sidebar-divider

Conversation

@jackiejou

@jackiejou jackiejou commented Jun 23, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Removes the border-left-color: transparent override on .bcs-NewActivityFeedContent.bcs-content in ActivityFeedV2.scss.
  • The divider between the sidebar nav tabs and the v2 feed now renders again.

Test plan

  • Open the content sidebar with the v2 activity feed and confirm the left border / divider between the nav tabs and the feed is visible.
  • Confirm no other sidebar layouts regressed.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed a display issue where a divider between navigation tabs and the activity feed was not visible. The divider now displays with its default styling.

@jackiejou
fix(activity-feed-v2): restore sidebar content left border
3dfd277 
Removes the border-left-color: transparent override on
.bcs-NewActivityFeedContent.bcs-content so the divider between the
nav tabs and the v2 feed renders again.
@jackiejou
jackiejou requested review from a team as code owners June 23, 2026 18:14
@coderabbitai

coderabbitai Bot commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 43c85f42-9508-4aac-9da7-5a3530a837b4

📥 Commits

Reviewing files that changed from the base of the PR and between 92f54fe and 3dfd277.

📒 Files selected for processing (1)
  • src/elements/content-sidebar/activity-feed-v2/ActivityFeedV2.scss
💤 Files with no reviewable changes (1)
  • src/elements/content-sidebar/activity-feed-v2/ActivityFeedV2.scss

Walkthrough

Removes a 5-line SCSS block in ActivityFeedV2.scss that overrode border-left-color to transparent on the &.bcs-content variant, so the divider between the nav tabs and the v2 activity feed now follows default styles.

Changes

Divider visibility in ActivityFeedV2

Layer / File(s) Summary
Remove transparent divider override
src/elements/content-sidebar/activity-feed-v2/ActivityFeedV2.scss		 Deletes the &.bcs-content SCSS rule that set border-left-color: transparent, restoring default divider styling between the nav tabs and the v2 activity feed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • box/box-ui-elements#4625: Directly modifies ActivityFeedV2.scss around the same border-left-color: transparent / left-divider styling for .bcs-content / .bcs-NewActivityFeedContent.
  • box/box-ui-elements#4626: Documents the same divider-hiding behavior that this PR's removal of border-left-color: transparent targets.

Suggested labels

ready-to-merge

Suggested reviewers

  • reneshen0328
  • JChan106
  • ahorowitz123

Poem

🐇 A border once hidden, transparent and shy,
Now shown to the world as the tabs roll on by.
I nibbled the SCSS, just five lines away,
The divider returns to hold firmly in place.
The feed and its nav share a visible seam — hooray! 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: restoring the sidebar content left border in the activity-feed-v2 component.
Description check ✅ Passed The description provides a clear summary of the change and includes a comprehensive test plan, though it deviates from the provided template structure.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mergify

mergify Bot commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Queued — the merge queue status continues in this comment ↓.

@mergify mergify Bot added the queued label Jun 23, 2026
@mergify

mergify Bot commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • ✅ Entered queue — 2026-06-23 18:35 UTC · Rule: Automatic strict merge · triggered by rule Automatic merge queue
  • ✅ Checks skipped · PR is already up-to-date
  • ✅ Merged — 2026-06-23 18:35 UTC · at 3dfd277ebfb8b56275e79bdbd71fb4964164e062 · squash

This pull request spent 14 seconds in the queue, including 2 seconds running CI.

Required conditions to merge

@mergify
mergify Bot merged commit dd94a1b into box:master Jun 23, 2026
10 of 11 checks passed
@mergify mergify Bot removed the queued label Jun 23, 2026
@coderabbitai coderabbitai Bot mentioned this pull request Jun 24, 2026
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahorowitz123 ahorowitz123 ahorowitz123 approved these changes
@zhirongwang zhirongwang zhirongwang approved these changes

Assignees

No one assigned

Labels

ready-to-merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jackiejou @ahorowitz123 @zhirongwang