feat(content-uploader): controlled expanded state by dealwith · Pull Request #4629 · box/box-ui-elements

dealwith · 2026-06-15T15:38:27Z

This PR is a part of making an expanded state persistent. The persistent logic will be handled from the outside.

Added isExpanded and onToggle props
Logic without isExpanded and onToggle preserved
Tests added

Summary by CodeRabbit

New Features
- The uploads manager now supports parent-controlled expand/collapse via new optional props to set the expanded state and receive toggle events.
- Auto-expand and minimize/reset behaviors now consistently respect controlled mode, keeping internal expansion from changing unexpectedly.
Tests
- Added Jest coverage for controlled vs. uncontrolled modes, including onToggle callback behavior, auto-expand threshold handling, and ensuring reset/minimize don’t mutate internal expanded state or fire callbacks in controlled mode.

coderabbitai · 2026-06-15T15:39:23Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

Walkthrough

ContentUploader adds two optional props, isExpanded and onToggle, to support a controlled expand/collapse mode for the uploads manager. Two new helpers (isExpandControlled, getIsExpanded) resolve the effective expansion state, and all internal methods (expandUploadsManager, toggleUploadsManager, resetUploadManagerExpandState, addToQueue) are updated to skip internal state mutations when controlled. Render and queue-reset logic also switch to the resolved helper value.

Changes

Controlled Expand/Collapse for Uploads Manager

Layer / File(s)	Summary
Props and expand-state resolution helpers `src/elements/content-uploader/ContentUploader.tsx`	Adds `isExpanded?: boolean` and `onToggle?: (isExpanded: boolean) => void` to `ContentUploaderProps`. Introduces `isExpandControlled()` and `getIsExpanded()` to pick between the controlled prop and `state.isUploadsManagerExpanded`. Updates `resetUploadManagerExpandState` to skip internal state mutation when controlled.
Internal method guards for controlled mode `src/elements/content-uploader/ContentUploader.tsx`	`addToQueue` reads expanded state through `getIsExpanded()`. `expandUploadsManager` returns early in controlled mode. `toggleUploadsManager` delegates to `onToggle(!isExpanded)` and skips `setState` when controlled. `resetUploadsManagerItemsWhenUploadsComplete` uses `getIsExpanded()` instead of destructuring state directly.
Render wiring and controlled/uncontrolled tests `src/elements/content-uploader/ContentUploader.tsx`, `src/elements/content-uploader/__tests__/ContentUploader.test.js`	`render` derives `isUploadsManagerExpanded` from `getIsExpanded()` before passing it to `UploadsManager`. New Jest suite covers: controlled prop-driven `isExpanded` forwarding to `UploadsManagerBP`, `toggleUploadsManager` calling `onToggle` without mutating state (controlled) vs. flipping state without calling `onToggle` (uncontrolled), auto-expand threshold no-ops, and `resetUploadManagerExpandState` no-ops in controlled mode.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

box/box-ui-elements#4573: Directly sets isExpanded on UploadsManagerBP from state.isUploadsManagerExpanded in the modernized path — the same prop integration point this PR upgrades to support controlled mode.

Suggested labels

ready-to-merge

Suggested reviewers

reneshen0328
jpan-box
olehrybak

Poem

🐇 A toggle was once just a boolean flip,
Now the consumer can steer the ship!
isExpanded in hand, onToggle to call,
Controlled or uncontrolled — it handles them all.
The uploads manager bows to your will,
And the bunny hops on with a thrill! 🎉

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The PR title clearly and concisely describes the main change: adding controlled expanded state support to the content-uploader component.
Description check	✅ Passed	The PR description clearly outlines the changes (new props, backward compatibility, tests) and the overall objective (making expanded state persistent), providing sufficient context for reviewers.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch uploads-manager-controlled-expand

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/elements/content-uploader/__tests__/ContentUploader.test.js`:
- Around line 700-714: The current test only covers the collapsed to expanded
transition (isExpanded: false → true). Add a complementary regression test case
in the same test file that covers the expanded to collapsed transition
(isExpanded: true → false) after completed uploads. Create a new test using the
same pattern as toggleUploadsManager in controlled mode, but initialize the
wrapper with isExpanded: true, call toggleUploadsManager, expect onToggle to be
called with false, verify that internal state remains true (controlled mode),
and assert that the minimize and cleanup side effects execute properly to
prevent stranding completed items in the controlled path.

In `@src/elements/content-uploader/ContentUploader.tsx`:
- Around line 1373-1380: The toggleExpand method in ContentUploader.tsx skips
side effects when the component is in controlled mode. When isExpandControlled()
returns true and the manager is being collapsed, the method only calls onToggle
but doesn't execute the necessary minimize side effects including onMinimize
callback, isAutoExpanded reset, and the post-collapse cleanup timer, which can
leave completed items stuck. Modify the controlled branch to check if isExpanded
is true (meaning we're collapsing), and if so, also invoke the same minimize
side effects that would normally run via minimizeUploadsManager(), ensuring
these cleanup operations happen regardless of whether the expand state is
controlled or uncontrolled.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d8edf8f1-1c1c-47d7-8f96-8986dd5b4b88

📥 Commits

Reviewing files that changed from the base of the PR and between 7f63ba1 and 4ba303a.

📒 Files selected for processing (2)

src/elements/content-uploader/ContentUploader.tsx
src/elements/content-uploader/__tests__/ContentUploader.test.js

olehrybak

Overall lgtm, left a small comment

mergify · 2026-06-16T14:52:24Z

mergify · 2026-06-16T15:53:13Z

* feat(content-uploader): controlled expanded state * feat(content-uploader): run onToggle uncontrolled * test(content-uploader): controlled-mode assertions * refactor(content-uploader): simplify branching --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

dealwith marked this pull request as ready for review June 15, 2026 15:39

dealwith requested review from a team as code owners June 15, 2026 15:39

coderabbitai Bot reviewed Jun 15, 2026

View reviewed changes

Comment thread src/elements/content-uploader/__tests__/ContentUploader.test.js

Comment thread src/elements/content-uploader/ContentUploader.tsx Outdated

olehrybak previously approved these changes Jun 15, 2026

View reviewed changes

Comment thread src/elements/content-uploader/ContentUploader.tsx Outdated

jfox-box reviewed Jun 15, 2026

View reviewed changes

Comment thread src/elements/content-uploader/ContentUploader.tsx Outdated

dealwith dismissed olehrybak’s stale review via 24023da June 16, 2026 12:15

olehrybak previously approved these changes Jun 16, 2026

View reviewed changes

dealwith dismissed olehrybak’s stale review via 1082dc6 June 16, 2026 13:38

Omfalos approved these changes Jun 16, 2026

View reviewed changes

dealwith added 4 commits June 16, 2026 16:12

feat(content-uploader): controlled expanded state

5c4d574

feat(content-uploader): run onToggle uncontrolled

34fb0ec

test(content-uploader): controlled-mode assertions

b92eb3a

refactor(content-uploader): simplify branching

9eaeacd

dealwith force-pushed the uploads-manager-controlled-expand branch from 4965d82 to 9eaeacd Compare June 16, 2026 14:15

dealwith self-assigned this Jun 16, 2026

dealwith requested a review from jfox-box June 16, 2026 14:44

jfox-box approved these changes Jun 16, 2026

View reviewed changes

dealwith added the ready-to-merge label Jun 16, 2026

mergify Bot added the queued label Jun 16, 2026

Merge branch 'master' into uploads-manager-controlled-expand

49128de

mergify Bot added dequeued queued and removed queued labels Jun 16, 2026

Merge branch 'master' into uploads-manager-controlled-expand

bee211c

mergify Bot removed the dequeued label Jun 16, 2026

mergify Bot merged commit c3d21b1 into master Jun 16, 2026
13 checks passed

mergify Bot deleted the uploads-manager-controlled-expand branch June 16, 2026 16:04

mergify Bot removed the queued label Jun 16, 2026

coderabbitai Bot mentioned this pull request Jun 16, 2026

feat: implement open/closing logic for modernized content uploader #4628

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(content-uploader): controlled expanded state#4629

feat(content-uploader): controlled expanded state#4629
mergify[bot] merged 6 commits into
masterfrom
uploads-manager-controlled-expand

dealwith commented Jun 15, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 15, 2026 •

edited

Loading

Reviews paused

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

olehrybak left a comment

Uh oh!

Uh oh!

Uh oh!

mergify Bot commented Jun 16, 2026 •

edited

Loading

Uh oh!

mergify Bot commented Jun 16, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

dealwith commented Jun 15, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

olehrybak left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mergify Bot commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Reason

Hint

Uh oh!

mergify Bot commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dealwith commented Jun 15, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 15, 2026 •

edited

Loading

mergify Bot commented Jun 16, 2026 •

edited

Loading

mergify Bot commented Jun 16, 2026 •

edited

Loading