This repository was archived by the owner on May 19, 2021. It is now read-only.
Output buffering during buildFrom* functions#25
Open
vaind wants to merge 1 commit intobox-project:masterfrom
Open
Output buffering during buildFrom* functions#25vaind wants to merge 1 commit intobox-project:masterfrom
vaind wants to merge 1 commit intobox-project:masterfrom
Conversation
Contributor
|
I did a quick performance test using Symfony and got the following results: Before PR: After PR: Could you provide me with your own benchmarks with details on what you built to perform the test? |
Author
|
I was finally able to test this. The PR improves performance on HDD but you are right, it really does decrease perf. on SSD (or any other fast IO drive, e. g. /tmp mounted in RAM). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves performance by ~ 20 % if there are a lot of files
see the original pull request #21