Fix indexing issue for output monitoring#3389
Open
Steven-Roberts wants to merge 1 commit into
Open
Conversation
dschwoerer
reviewed
Jun 15, 2026
dschwoerer
left a comment
dschwoerer
left a comment
Contributor
There was a problem hiding this comment.
Does this break the output? I think there are somewhere some tricky details, especially with smaller / slower output monitors, that make things a bit non-intuitive ...
Contributor
|
Why not change the check to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Output monitoring functions would get called twice in a row with
iter = 0(unlessdump_on_restart = false) and would never reach iterationNOUTwhich was used as a check for cleanup:BOUT-dev/src/solver/solver.cxx
Line 931 in c7020b4
This PR fixes solver iterations to be 1-indexed.