Skip to content

Pytest integrated#3331

Open
tomc271 wants to merge 203 commits into
nextfrom
pytest-integrated
Open

Pytest integrated#3331
tomc271 wants to merge 203 commits into
nextfrom
pytest-integrated

Conversation

@tomc271

@tomc271 tomc271 commented Mar 17, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

ZedThree
ZedThree reviewed Mar 18, 2026
View reviewed changes
Comment thread tests/run_integrated_tests.sh Outdated
Comment thread tests/run_integrated_tests.sh Outdated
Comment thread pyproject.toml
Comment thread CMakeLists.txt Outdated
Comment thread .ci_with_cmake.sh
Comment thread tests/integrated/test-boutpp/slicing/test_slicing.py Outdated
Comment thread tests/integrated/test-boutpp/slicing/test_slicing.py Outdated
Comment thread tests/integrated/test-boutpp/slicing/test_slicing.py Outdated
Comment thread tests/integrated/test-command-args/test_command_args.py Outdated
tomchapman added 29 commits April 14, 2026 12:12
@tomchapman
Use pytest rather than runtest as the command set in bout_add_integra…
a102ffe 
…ted_or_mms_test
@tomchapman
Rename runtest file to test-foo.py for each integrated test
a55dda0
@tomchapman
Rename runtest file to test-foo.py for each MMS test
053f62a
@tomchapman
Convert runtest file to use pytest for test_drift_instability
db34143
@tomchapman
Handle test files for tests named either test-foo or foo
0ed0750 
matching either to a file named `test_foo.py`.
@tomchapman
Handle test files with hyphens or prefixed with
fdd93e0
@tomchapman
Update symlink to renamed runtest file
f0b4405
@tomchapman
Rename more runtest files
4dd41cc
@tomchapman
Change filename Test run by tpc522 on Mon Nov 3 17:45:34 2025
0fa8b81 
Native configuration is x86_64-pc-linux-gnu

		===  tests ===

Schedule of variations:
    unix

Running target unix
Using /usr/share/dejagnu/baseboards/unix.exp as board description file for target.
Using /usr/share/dejagnu/config/unix.exp as generic interface file for target.

		===  Summary === to  in CMakeLists.txt
@tomchapman
Rename more runtest files
f9e2374
@tomchapman
Use PATH-based pytest executable
d00629c
@tomchapman
Fix more renamings
393ac3e
@tomchapman
Change custom_target check-integrated-tests to use pytest instead of …
4deaf22 
…ctest
@tomchapman
Some runtest files are shell scripts not python scripts, so revert …
82ff7ca 
…renaming
@tomchapman
Add python tests to run those runtest files that are not python scr…
681c2fb 
…ipts
@tomchapman
Convert test_cyclic.py to a valid pytest file
01cc49c
@tomchapman
Convert several more test files to work with pytest
09114fe
@tomchapman
Change directory before calling boutpp.init()
be04639 
so that the `input` directory is found.
@tomchapman
Change directory before calling boutpp.init()
abe75f2 
so that the `test` directory is found.
@tomchapman
Change directory before calling boutpp.Field3D.fromCollect()
52436a8 
so that the `data` directory is found.
@tomchapman
Modify more test files for running via pytest
f7378bc
@tomchapman
MPI oversubscribe for communications test
5a959a2
@tomchapman
Change directory before removing files in data directory
e977ed6
@tomchapman
Modify test_communications to run via pytest
9afb0b2
@tomchapman
Modify test_delp2 to run via pytest
18b9c90
@tomchapman
Modify test_fci_boundary to run via pytest
c55ab8f 
Fails due to missing file `grid.fci.nc`.
@tomchapman
Modify test_fieldgroupcomm to run via pytest
125dd80 
Change directory to exe location prior to attempting to run it.
@tomchapman
Modify test_gyro to run via pytest
ede926e 
Change directory to exe location prior to attempting to run it.
@tomchapman
Modify test_interpolate to run via pytest
cc47c24 
Change directory to exe location prior to attempting to run it.
tomchapman added 15 commits May 13, 2026 13:38
@tomchapman
Pass value of CI environment variable to Fedora script
c5e89cf 
This is used in `run_integrated_tests.sh` to determine the verbosity level for pytest.
@tomchapman
Remove unused imports
516c483
@tomchapman
Apply prek formatting
d834f9f
@tomchapman
Merge remote-tracking branch 'remotes/boutproject/next' into pytest-i…
6a6c82e 
…ntegrated
@tomchapman
Convert test_unused_options to run via pytest
a36dcdd
@tomchapman
Remove obsolete imports for Python2
0c91d13
@tomchapman
Apply ruff fixes
183346a
@tomchapman
Remove unused variable
8f0131e
@tomchapman
Fix ruff issue: "E402 Module level import not at top of file"
dd61eb3
@tomchapman
Remove assignment to unused variable nxpe
e9c9f7d
@tomchapman
E402 Module level import not at top of file
38beaf4
@tomchapman
E402 Module level import not at top of file
d9db8dc
@tomchapman
E402 Module level import not at top of file
f75cf19
@tomchapman
E712 Avoid inequality comparisons to False; use log: for truth ch…
a59b93b 
…ecks
@tomchapman
Explicitly pass x, y, z as a dictionary to eval()
b6b4e1c 
to prevent type-checker warnings.
@tomc271 tomc271 force-pushed the pytest-integrated branch from 303d76c to b6b4e1c Compare May 15, 2026 15:24
@tomc271 tomc271 force-pushed the pytest-integrated branch from 9cf1c95 to 3e91b3a Compare June 11, 2026 08:52
@tomc271 tomc271 force-pushed the pytest-integrated branch from 3e91b3a to 7f920ac Compare June 11, 2026 12:48
dschwoerer
dschwoerer requested changes Jun 15, 2026
View reviewed changes

@dschwoerer dschwoerer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems one of the MMS tests is missing. That certainly needs fixing.

I find it also increadibly hard to review, as in some case the rename from runtest to test_* is not rendered correctly on github. In some cases this seems to be done such that git itself is not aware of the the rename, e.g. test-fci-mpi/runtest.

This makes it even harder to figure out what was changed, as you clearly did not write the whole test new.

I have reviewed test-fci-mpi/runtest more carefully, and it is doing only part what is in next. It is skipping the iteration over the different test cases:
https://github.com/boutproject/BOUT-dev/blob/next/tests/integrated/test-fci-mpi/runtest#L49

Also, it would only output the errors after the assert:

BOUT-dev/tests/integrated/test-fci-mpi/test_fci_mpi.py

Line 72 in 7f920ac

assert success, "\nSome tests failed:"

So this is never printed.

Comment thread tests/integrated/test-fieldgroupComm/test_fieldgroupComm.py
# Requires: netcdf
# Requires: not metric_3d
# Cores: 4

@dschwoerer dschwoerer Jun 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt the current test system still parses and process them, so the can be removed?

@dschwoerer

dschwoerer commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

I forgot - the new pytest is much faster, which is nice, but I am wondering this comes from skipping tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZedThree ZedThree ZedThree left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@dschwoerer dschwoerer dschwoerer requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tomc271 @ZedThree @dschwoerer @tomchapman