chore: update opapi deps#692
Conversation
Greptile SummaryThis PR updates opapi's build and OpenAPI type-generation stack. The main changes are:
Confidence Score: 4/5The package build path needs fixes before merging.
opapi/package.json Important Files Changed
Reviews (1): Last reviewed commit: "chore: update opapi deps" | Re-trigger Greptile |
| "scripts": { | ||
| "test": "vitest run", | ||
| "build": "tsup src/index.ts --dts --format cjs,esm --clean", | ||
| "build": "tsdown", |
There was a problem hiding this comment.
Build Output Contract Can Drift
The old command explicitly built src/index.ts with CJS, ESM, declarations, and a clean output, but bare tsdown now relies on default discovery. If tsdown does not emit the same dist/index.js, dist/index.mjs, and dist/index.d.ts files referenced by this package, the release can build with missing or renamed artifacts and consumers will fail to resolve the package.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| "prettier": "3.4.1", | ||
| "ts-node": "10.9.2", | ||
| "tsup": "8.3.5", | ||
| "tsdown": "0.22.4", |
There was a problem hiding this comment.
Build Tool Requires Newer Node
The new tsdown toolchain pulls in rolldown native bindings with a Node floor of ^20.19.0 || >=22.12.0, but the package does not declare that runtime requirement. CI or local builds on older supported Node versions can install dependencies and then fail when pnpm build runs.
This dependency update PR replaces tsup with tsdown and updates openapi-typescript. The opapi version is bumped a patch to
1.0.1.The tsdown upgrade catches and fixes some issues with exported types.
The openapi-typescript upgrade comes with some improvements to generator types to make them both more accurate and lax.