Skip to content

Depend on ros_environment where needed#24

Merged
Gabriela-AdrianaLapuste merged 1 commit intobosch-engineering:rolling-develfrom
wentasah:fix-environment-dep
Jan 13, 2026
Merged

Depend on ros_environment where needed#24
Gabriela-AdrianaLapuste merged 1 commit intobosch-engineering:rolling-develfrom
wentasah:fix-environment-dep

Conversation

@wentasah
Copy link
Copy Markdown
Contributor

Recent commit f4e9860 ("Update dependency declarations for target_link_libraries", 2025-11-04) introduced dependency on ROS_DISTRO environment variable. Such an variable is only set if ros_environment package is available, but package.xml doesn't mention ros_environment as dependency.

This can lead to the following error when building the package without ros_environment (e.g. when using the Nix package manager):

-- Found pcl_conversions: 2.4.5 (/.../ros-humble-pcl-conversions-2.4.5-r2/share/pcl_conversions/cmake)
...
[ 50%] Building CXX object CMakeFiles/off_highway_general_purpose_radar.dir/src/receiver.cpp.o
/build/off_highway_sensor_drivers-release-release-humble-off_highway_general_purpose_radar-0.10.0-1/src/receiver.cpp:20:10:
fatal error: pcl_conversions/pcl_conversions.h: No such file or directory
   20 | #include "pcl_conversions/pcl_conversions.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This commit adds dependency on ros_environment to packages where it is needed.

Recent commit f4e9860 ("Update dependency declarations for
target_link_libraries", 2025-11-04) introduced dependency on
ROS_DISTRO environment variable. Such an variable is only set if
ros_environment package is available, but package.xml doesn't mention
ros_environment as dependency.

This can lead to the following error when building the package without
ros_environment (e.g. when using the Nix package manager):

    -- Found pcl_conversions: 2.4.5 (/.../ros-humble-pcl-conversions-2.4.5-r2/share/pcl_conversions/cmake)
    ...
    [ 50%] Building CXX object CMakeFiles/off_highway_general_purpose_radar.dir/src/receiver.cpp.o
    /build/off_highway_sensor_drivers-release-release-humble-off_highway_general_purpose_radar-0.10.0-1/src/receiver.cpp:20:10:
    fatal error: pcl_conversions/pcl_conversions.h: No such file or directory
       20 | #include "pcl_conversions/pcl_conversions.h"
          |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This commit adds dependency on ros_environment to packages where it is
needed.

Signed-off-by: Michal Sojka <michal.sojka@cvut.cz>
@Timple
Copy link
Copy Markdown
Contributor

Timple commented Jan 13, 2026

Buildfarm is not compiling the package because of this.

Can this be merged and a new (bloom) release be created?

@MCFurry
Copy link
Copy Markdown
Contributor

MCFurry commented Jan 13, 2026

This would be great to get in, currently the latest released version (1.1.0) is not in the apt-repositories because the buildfarm fails on exactly this.

@Gabriela-AdrianaLapuste Gabriela-AdrianaLapuste merged commit 51a540f into bosch-engineering:rolling-devel Jan 13, 2026
@Timple
Copy link
Copy Markdown
Contributor

Timple commented Jan 16, 2026

Thank you for merging @Gabriela-AdrianaLapuste
This is currently a regression for the next sync: https://discourse.openrobotics.org/t/preparing-for-jazzy-sync-and-patch-release-2026-01-22/51865

If you manage to put out a bloom release today or tomorrow it might make it before the next sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants