feat: grain-aware join_one via is_entity dimensions#219
Merged
hussainsultan merged 2 commits intomainfrom Apr 15, 2026
Merged
Conversation
8 tasks
|
Proposed solution is clean and the outcome intuitive for users. I'm not familiar with entity in this context however, why not And how would this work for 'equivalent' columns? I imagine having both Note that I'm still studying BSLs internals and do not fully understand the inner workings yet. But i feel there should be an even more intuitive way. Something like pre-aggregation by default, using the columns used in the join. |
boringdata
force-pushed
the
worktree-issue-218-grain-aware-joins
branch
from
731d8f3 to
deccd95
Compare
) Pre-existing tagged payloads serialized before cardinality was emitted have no 'cardinality' key. Defaulting to 'one' would silently skip pre-aggregation on former join_many joins. Default to 'many' instead since it is the safe superset. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
boringdata
force-pushed
the
worktree-issue-218-grain-aware-joins
branch
from
82ca324 to
1b4f5fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #218
Closes #223
Related: #64 — this PR lays the groundwork for deferred
join_oneoptimization by establishingis_entityas the primary key / grain conceptChanges
is_entityattribute onDimensionmarks primary-key / grain columnsjoin_one()auto-detects grain mismatch via entity dim comparison and upgrades tojoin_manywith a warning"many"(safe for legacy payloads)