fix repository compression size#1751
Draft
henry-spanka wants to merge 2 commits intoborgbase:masterfrom
Draft
Conversation
Contributor
|
Hi @henry-spanka, Thanks for this PR! Appreciate the work. Just ran it locally and I think it needs some additional discussion:
The other checks you added while processing the data should be fine. In your linked issue, you also suggest removing the field completely. Given the timing issue we have here, maybe that's better? Any replacement we could use instead? |
Collaborator
Maybe we can display |
Collaborator
I like that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
unique_csizefield was removed in commit f9d1260 as the field was dropped in Borg V2.This PR adds a check to only display the field in Borg V1.
Related Issue
Closes #1750
Motivation and Context
Currently the Compressed Size field displays N/A for new repos and a stale size for old repos which is never updated.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.