feat: block after vorta create and log status#1656
feat: block after vorta create and log status#1656diivi wants to merge 7 commits intoborgbase:masterfrom
Conversation
real-yfprojects
left a comment
There was a problem hiding this comment.
There is a problem: A second main window opens while the backup is running.
What do you suggest I do for the second window? If I close it, will it run in the background until it exits? |
Don't create a main window instance (nor a scheduler instance and so on). |
I changed the code so it only adds the message_received event to the other instance and nothing else. |
real-yfprojects
left a comment
There was a problem hiding this comment.
I notice that this can't handle when borg returns an error or when vorta --create is run twice simultaneously
…com/diivi/vorta into feat/block-create-and-return-status
My last commit should handle borg errors right? Also, how should I handle the second case? After handling Borg errors, I get this error when I run vorta --create twice simultaneously: |
I see this being outputted too, but it doesn't stop code execution. I think the current networking code can only handle one client at a time resulting in this message when the first (or maybe the second) client has disconnected. |
|
|
||
| init_translations(self) | ||
| self.message_received_event.connect(self.message_received_event_response) | ||
| if not args.profile: |
There was a problem hiding this comment.
if True is generally quicker to read than if not XX. And since we have a large code block under this condition now, it should get at least a comment on when this path is chosen. Still, keeping most of the code on the default path and dealing with exceptions some other way is preferable.
Description
Fixes #1380
blocks
vorta --createto log the result of the backing up operation.Motivation and Context
Better UX for
vorta --createHow Has This Been Tested?
Test GIF:

Types of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.