Argon2 via OpenSSL >= 3.2 - #9602
Open
ThomasWaldmann wants to merge 4 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9602 +/- ##
==========================================
- Coverage 87.05% 87.04% -0.01%
==========================================
Files 101 101
Lines 17848 17851 +3
Branches 2705 2709 +4
==========================================
+ Hits 15538 15539 +1
+ Misses 1609 1608 -1
- Partials 701 704 +3 ☔ View full report in Codecov by Harness. |
ThomasWaldmann
force-pushed
the
argon2-via-openssl32
branch
2 times, most recently
from
May 11, 2026 20:55
745ffbd to
b06e98b
Compare
ThomasWaldmann
marked this pull request as draft
May 11, 2026 20:55
Member
Author
|
Guess we need to wait for:
|
ThomasWaldmann
force-pushed
the
argon2-via-openssl32
branch
9 times, most recently
from
May 11, 2026 23:35
18e786b to
252cf06
Compare
ThomasWaldmann
force-pushed
the
argon2-via-openssl32
branch
4 times, most recently
from
June 11, 2026 08:39
8232e39 to
d70e1a5
Compare
ThomasWaldmann
force-pushed
the
argon2-via-openssl32
branch
5 times, most recently
from
June 15, 2026 13:05
f7e6aae to
7f16bc3
Compare
ThomasWaldmann
force-pushed
the
argon2-via-openssl32
branch
from
July 2, 2026 07:54
7f16bc3 to
21b6a76
Compare
ThomasWaldmann
force-pushed
the
argon2-via-openssl32
branch
from
July 6, 2026 18:11
21b6a76 to
0069733
Compare
ThomasWaldmann
force-pushed
the
argon2-via-openssl32
branch
from
August 2, 2026 08:20
0069733 to
a0e77d9
Compare
ThomasWaldmann
force-pushed
the
argon2-via-openssl32
branch
3 times, most recently
from
August 16, 2026 09:00
b396268 to
8b3f746
Compare
This was referenced Aug 16, 2026
- src/borg/crypto/low_level.pyx: implement `argon2_hash` using OpenSSL's `EVP_KDF` API for ARGON2 (requires OpenSSL >= 3.2.0). - src/borg/crypto/key.py: switch to the native `argon2_hash` implementation, removing `argon2-cffi` dependency. - setup.py: require OpenSSL >= 3.2.0 for the crypto extension to ensure ARGON2 KDF support is available. - pyproject.toml: drop `argon2-cffi` dependency. - docs: update installation requirements and security documentation to reflect the transition to OpenSSL for Argon2.
The inverted canary added in borgbackup#10097 watched for actions/setup-python gaining Python 3.12 support on the ubuntu-26.04 image. It went red on 2026-08-15 and 2026-08-16: the "Try to set up Python 3.12" step now succeeds, which was the whole point of the probe. Its job is done, so remove it. Older Pythons are therefore no longer categorically unavailable on ubuntu-26.04, so the matrix can gain multi-version coverage there once we move to those runners. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Borg on Linux now needs OpenSSL >= 3.2 for argon2, and ubuntu-24.04 ships OpenSSL 3.0.x, so the crypto extension no longer builds there. Move all Ubuntu-based jobs to ubuntu-26.04 (and ubuntu-24.04-arm to ubuntu-26.04-arm): ci.yml, canary.yml, bigendian.yml, codeql-analysis.yml, black.yaml, backport.yml and release.yml. The jobs that never build borg move along with them, so we do not end up with a confusing mix of runners. Ubuntu 26.04 ships glibc 2.43, so rename the built binaries from glibc239 to glibc243, in the native_tests matrix and in the EXPECTED_ASSETS list of the release workflow, which has to stay in sync with it. The Python versions stay as they are: actions/python-versions publishes 3.10 through 3.15 builds for the ubuntu-26.04 image, so setup-python can still provide the whole 3.11 .. 3.15-dev range we test. (When the image was new it only worked with its default 3.14, which is what the canary removed in the previous commit was watching for.) Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
ThomasWaldmann
force-pushed
the
argon2-via-openssl32
branch
from
August 16, 2026 12:39
8b3f746 to
3bb1eb3
Compare
ThomasWaldmann
marked this pull request as ready for review
August 16, 2026 13:18
Member
Author
|
Note: Delay merge after 2.0.0b23 release (give beta testers a bit more time in case they still run ubuntu 24.04 or some other dist with too old openssl). |
OpenSSL's Argon2 only uses threads if OSSL_set_max_threads() enabled the thread pool and a "threads" parameter > 1 is given - previously we always passed threads=1, so the 4 lanes of our default parallelism=4 were computed sequentially (argon2-cffi used real threads for the lanes, so unlocking got slower with the switch to OpenSSL). The thread count only affects speed, never the derived key (only the lanes parameter does), so this is fully compatible with existing keys. Apple M-series (OpenSSL 3.6.3), borg defaults (t=3, m=64 MiB, p=4): threads=1: 83 ms, threads=4: 29 ms (2.8x faster).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.