Skip to content

tests: restore coverage sigterm handling to investigate OpenBSD CI slowdown (#9463)#9465

Closed
CodeLoopdroid wants to merge 4 commits intoborgbackup:masterfrom
CodeLoopdroid:fix-openbsd-ci-sigterm
Closed

tests: restore coverage sigterm handling to investigate OpenBSD CI slowdown (#9463)#9465
CodeLoopdroid wants to merge 4 commits intoborgbackup:masterfrom
CodeLoopdroid:fix-openbsd-ci-sigterm

Conversation

@CodeLoopdroid
Copy link
Contributor

@CodeLoopdroid CodeLoopdroid commented Mar 11, 2026

Description

Restore sigterm = true under [tool.coverage.run] in pyproject.toml.

This follows the discussion in #9463 to test whether restoring the sigterm setting affects the OpenBSD CI runtime.

Checklist

  • PR is against master (or maintenance branch if only applicable there)
  • Tests pass (run tox or the relevant test subset)
  • New code has tests and docs where appropriate
  • Commit messages are clean and reference related issues

@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.06%. Comparing base (871c89b) to head (7df9cd9).
⚠️ Report is 10 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9465      +/-   ##
==========================================
- Coverage   83.30%   77.06%   -6.25%     
==========================================
  Files          87       87              
  Lines       15423    15429       +6     
  Branches     2310     2308       -2     
==========================================
- Hits        12848    11890     -958     
- Misses       1822     2854    +1032     
+ Partials      753      685      -68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThomasWaldmann
Copy link
Member

We have to also consider that there is quite some variance due to github runner load, see for example how long the ubuntu runs took.

@CodeLoopdroid
Copy link
Contributor Author

We have to also consider that there is quite some variance due to github runner load, see for example how long the ubuntu runs took.

In that case, should we compare a few more OpenBSD runs to see if the ~80–90 min pattern still holds?

@ThomasWaldmann
Copy link
Member

Well, we can't be sure, but it still looks slow. Try "parallel" next.

@ThomasWaldmann
Copy link
Member

Another aspect is that these options should not be OS-specific (AFAIK). But we'll see...

@CodeLoopdroid
Copy link
Contributor Author

Well, we can't be sure, but it still looks slow. Try "parallel" next.

Yeah, I’ll try that out.

@CodeLoopdroid
Copy link
Contributor Author

Try "parallel" next.

Should I remove the sigterm = true change and instead try adding the parallel approach?

@ThomasWaldmann
Copy link
Member

hmm, still slow.

@CodeLoopdroid
Copy link
Contributor Author

hmm, still slow.

Right.

@ThomasWaldmann
Copy link
Member

still slow.

i suspect that coverage enabled is just slow. and we now have enabled it for subprocess, so it is enabled for more code.

final experiment: remove subprocess. just for science.

@ThomasWaldmann
Copy link
Member

ThomasWaldmann commented Mar 12, 2026

OK, now openbsd is faster again, 1st run 33mins, 2nd run: 35mins.

The subprocess patch made it slower. But as we need subprocess coverage, guess there is no choice.

@CodeLoopdroid
Copy link
Contributor Author

OK, now openbsd is faster again, 33mins (I will restart that test run to get another measurement).

The subprocess patch made it slower. But as we need subprocess coverage, guess there is no choice.

Right.

@ThomasWaldmann
Copy link
Member

I filed an issue about coverage speed, but guess we can't solve it right now in this PR.

Thanks for working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants