respect XDG_CONFIG_HOME if set #135
Merged
+68
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds support for respecting the XDG_CONFIG_HOME environment variable when creating new configuration files, improving adherence to XDG Base Directory standards on Unix-like systems. The PR also includes minor improvements to error message consistency and documentation formatting.
Changes:
- Add XDG_CONFIG_HOME support for new config file creation in cmd/root.go
- Standardize error message capitalization (lowercase sentence start) across client code
- Update README documentation and improve code block formatting (bash → sh, proper indentation)
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| cmd/root.go | Implements XDG_CONFIG_HOME environment variable support when creating new config files, with fallback to home directory dotfile |
| client/lessons.go | Normalizes error message capitalization from "To run" to "to run" |
| client/auth.go | Normalizes error message capitalization from "To run" to "to run" |
| README.md | Updates documentation about config file location and improves formatting (bash→sh, proper indentation of nested content) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
theodore-s-beers
force-pushed
the
tsb_xdg
branch
from
d18cfe9 to
6d0fd4b
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Mufeed Ali <me@mufeed.dev>
theodore-s-beers
force-pushed
the
tsb_xdg
branch
from
6d0fd4b to
efa1460
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #100. I favored a different implementation but have added the author of that PR as a co-author here.