libvirt: add --console-log and --platform-console-log options#264
Open
cgwalters wants to merge 1 commit into
Open
libvirt: add --console-log and --platform-console-log options#264cgwalters wants to merge 1 commit into
cgwalters wants to merge 1 commit into
Conversation
The motivation is making debugging easier for automated testing. The console situation is messy - in bootc's CI we always inject `hvc0` but that's not yet a standard across distros/OSes which maeks things messy. We often end up with both hvc0 and a platform-specific console (which may be better supported by the bootloader), so support logging both to a file. Assisted-by: OpenCode (Claude Sonnet 4.6) Signed-off-by: Colin Walters <walters@verbum.org>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces functionality to log virtio and serial console output to host files for libvirt-managed VMs. It adds new CLI arguments '--console-log' and '--platform-console-log', updates the 'DomainBuilder' to support these configurations, and includes logic to pre-create and validate log file paths to prevent conflicts. Additionally, it adds integration tests and documentation examples. I have no feedback to provide as there were no review comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The motivation is making debugging easier for automated testing. The console situation is messy - in bootc's CI we always inject
hvc0but that's not yet a standard across distros/OSes which maeks things messy.We often end up with both hvc0 and a platform-specific console (which may be better supported by the bootloader), so support logging both to a file.
Assisted-by: OpenCode (Claude Sonnet 4.6)