fix: add -Wmaybe-uninitialized pragma to union storage constructors#145
Open
alandefreitas wants to merge 1 commit intoboostorg:developfrom
Open
fix: add -Wmaybe-uninitialized pragma to union storage constructors#145alandefreitas wants to merge 1 commit intoboostorg:developfrom
alandefreitas wants to merge 1 commit intoboostorg:developfrom
Conversation
GCC 7+ produces false-positive -Wmaybe-uninitialized warnings at -O3 when deeply inlining through union constructors that initialize one member while another (dummy_) exists. This is the same class of false positive addressed in boostorg/variant2#55. The pragmas are placed around the forwarding constructors in both constexpr_union_storage_t and fallback_union_storage_t.
alandefreitas
force-pushed
the
fix/maybe-uninitialized-pragma
branch
from
f6bcfaa to
88e2378
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC 7+ at
-O3produces false-positive-Wmaybe-uninitializedwarnings when inlining through theconstexpr_union_storage_tandfallback_union_storage_tconstructors. Same class of false positive as boostorg/variant2#55 — union with a dummy and value member, constructor initializes value.Adds scoped pragmas around both forwarding constructors in
union_optional.hpp.Refs boostorg/url#981