feat(prompts,core): make autocomplete placeholder tabbable#485
Open
feat(prompts,core): make autocomplete placeholder tabbable#485
Conversation
🦋 Changeset detectedLatest commit: 099430f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
natemoo-re
reviewed
Mar 11, 2026
| if (this.userInput === '\t') { | ||
| this._clearUserInput(); | ||
| } | ||
| this._setUserInput(this.#placeholder, true); |
Member
There was a problem hiding this comment.
Hmm, would this set the value to something other than options? Seems like we'd only want to enable this if placeholder exists within options
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds tabbable placeholder for autocomplete: when you set a non-empty placeholder and the field is empty, tab fills it with that text so options filter and you can confirm with enter.
closes #480.