Draft
Conversation
Author
|
Changing this to draft while waiting for GitLab to implement signed webhooks, which seems like might happen soon: https://gitlab.com/gitlab-org/gitlab/-/work_items/19367 Based on the issue description, the signature will be "an HMAC-SHA256 hex digest of |
The signature verification now matches planned implementation: https://gitlab.com/gitlab-org/gitlab/-/work_items/19367
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements support for handling GitLab events.
The
PyGHeeclass is configurable for GH vs. GL using theevent_sourceparameter, which defaults to'github'.When it is configured to handle GitHub events it should function as before, meaning that this PR (hopefully) does not contain any breaking changes.
This implementation assumes that some intermediary, e.g. a custom Smee server, uses the webhook secret to sign the event and add an
X-Gitlab-Signatureheader since GitLab does not yet support webhook signatures.I'm open to making both major and minor changes if you have any suggestions. I personally think the if/elif/elses look a bit messy, especially in the constructor.