Conversation
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
=======================================
Coverage 30.03% 30.03%
=======================================
Files 8 8
Lines 473 473
=======================================
Hits 142 142
Misses 315 315
Partials 16 16 Continue to review full report at Codecov.
|
bobheadxi
left a comment
There was a problem hiding this comment.
Seems like a cool thing to have! 🚀
Have you taken a look at entrypoint.sh? I wonder if it might be possible to use that script here so that there is consistency in behaviour across the GitHub Action and this orb 🤔
Co-authored-by: Robert Lin <robertlin1@gmail.com>
|
No I haven't, I will take a look at the entrypoint script though, thanks! edit: I think it will be possible to mirror the |
|
Alright I've got feature parity with how the github actions behave. One question, the pr checks capabilities, does it cause PR CI builds to fail?. edit: Now that there's basic parity in place, i'll try to use the |
You could do some renaming to make the env vars match up - the only specific ones are I imagine CircleCI exports similar variables during CI runs! |
Overview
Opening this up to get some initial feedback. The idea behind this orb is to enable a CircleCI equivalent of the GitHub Actions capabilities of
gobenchdata.Changes
rtradeltd/gobenchdataTODO
EnablechecksEnable uploading new benchmark data to specified branch