Skip to content

Reduction but same results#1

Open
bmchalenv wants to merge 37 commits intomainfrom
topics_parameters_small_but_feature_complete
Open

Reduction but same results#1
bmchalenv wants to merge 37 commits intomainfrom
topics_parameters_small_but_feature_complete

Conversation

@bmchalenv
Copy link
Owner

@bmchalenv bmchalenv commented Jan 10, 2026

No description provided.

bmchalenv added 30 commits January 2, 2026 10:30
@bmchalenv
Add controlling topic expected frequencies and tolerances through ROS…
256a121 
… 2 parameters

Signed-off-by: Blake McHale <bmchale@nvidia.com>
@bmchalenv
Add tests for nested YAML and don't specify the topics parameter ever…
596cc53 
…y time

Signed-off-by: Blake McHale <bmchale@nvidia.com>
@bmchalenv
More common functions and use rclpy instead of subprocess for interfa…
2f31969 
…cing with parameters

Signed-off-by: Blake McHale <bmchale@nvidia.com>
@bmchalenv
Fix cpplint
e78aca3 
Signed-off-by: Blake McHale <bmchale@nvidia.com>
@bmchalenv
Fix lint
b891a6b 
Signed-off-by: Blake McHale <bmchale@nvidia.com>
@bmchalenv
Fix tests
eb488e3 
Signed-off-by: Blake McHale <bmchale@nvidia.com>
@bmchalenv
Don't maintain pending_topic_configs_
4fdc70c 
Signed-off-by: Blake McHale <bmchale@nvidia.com>
@bmchalenv
Use same base class for RosNodeTestCase
f715325 
Signed-off-by: Blake McHale <bmchale@nvidia.com>
@bmchalenv
Update copyrights
31e9148 
Signed-off-by: Blake McHale <bmchale@nvidia.com>
@bmchalenv
More tests and linting
88ddcd2 
Signed-off-by: Blake McHale <bmchale@nvidia.com>
@bmchalenv
Cover when topics is specified alongside its subfields
ad2aacb 
Signed-off-by: Blake McHale <bmchale@nvidia.com>
@bmchalenv
Move code inline and add param delete
61c898f 
Signed-off-by: Blake McHale <bmchale@nvidia.com>
@bmchalenv
Catch exceptions with declare
99f2981 
Signed-off-by: Blake McHale <bmchale@nvidia.com>
@bmchalenv
Fix typo
de7b899 
Signed-off-by: Blake McHale <bmchale@nvidia.com>
@bmchalenv
Reject non-numeric parameters and allow both int and double
4ef8db8 
Signed-off-by: Blake McHale <bmchale@nvidia.com>
@bmchalenv
Add tests for deleting and setting invalid parameters
6fa7976 
Signed-off-by: Blake McHale <bmchale@nvidia.com>
@bmchalenv
Fix lint
53b052a 
Signed-off-by: Blake McHale <bmchale@nvidia.com>
@bmchalenv
Move parameters to greenwave_diagnostics.hpp
82971d7 
Signed-off-by: Blake McHale <bmchale@nvidia.com>
@bmchalenv
Add parameter tests to test_greenwave_diagnostics
cc67a22 
Signed-off-by: Blake McHale <bmchale@nvidia.com>
@bmchalenv
More tests. One consolidated test no deletions.
154d35e 
Signed-off-by: Blake McHale <bmchale@nvidia.com>
@bmchalenv
Remove old test files
b9292b3 
Signed-off-by: Blake McHale <bmchale@nvidia.com>
@bmchalenv
Refactor UI adaptor
e0327dd 
Signed-off-by: Blake McHale <bmchale@nvidia.com>
@bmchalenv
Use parameters instead of ManageTopic
e4d02af 
Signed-off-by: Blake McHale <bmchale@nvidia.com>
@bmchalenv
Fix CI tests
b8e6141 
Signed-off-by: Blake McHale <bmchale@nvidia.com>
@bmchalenv
Fix CI issues
37aee84 
Signed-off-by: Blake McHale <bmchale@nvidia.com>
@bmchalenv
Remove last monitor-interfaces reference
136f3a7 
Signed-off-by: Blake McHale <bmchale@nvidia.com>
@bmchalenv
Test no destructor
658dc50 
Signed-off-by: Blake McHale <bmchale@nvidia.com>
@bmchalenv
Try to fix CI
01c3f09 
Signed-off-by: Blake McHale <bmchale@nvidia.com>
@bmchalenv
Small fixes to improve destructor safety
c4273fd 
Signed-off-by: Blake McHale <bmchale@nvidia.com>
@bmchalenv
Fix ROS race conditions during initialization
c78675c 
Signed-off-by: Blake McHale <bmchale@nvidia.com>
@bmchalenv
Fix lint
7308ae0 
Signed-off-by: Blake McHale <bmchale@nvidia.com>
@bmchalenv
Small greptile fixups
7f1c64f 
Signed-off-by: Blake McHale <bmchale@nvidia.com>
@bmchalenv
Fix lint
97a8f80 
Signed-off-by: Blake McHale <bmchale@nvidia.com>
@bmchalenv
Reduction but same results
c2c4afd 
Signed-off-by: Blake McHale <bmchale@nvidia.com>
@bmchalenv bmchalenv changed the base branch from topics_parameters to main January 10, 2026 10:45
@bmchalenv
Reduce and remove logic optimizations
19e96a3 
Signed-off-by: Blake McHale <bmchale@nvidia.com>
@bmchalenv bmchalenv changed the base branch from main to topics_parameters January 10, 2026 18:33
@bmchalenv bmchalenv changed the base branch from topics_parameters to main January 10, 2026 18:33
@bmchalenv
Longer delay to find topics. Better error during deferred init
d5191db 
Signed-off-by: Blake McHale <bmchale@nvidia.com>
@bmchalenv
Small cleaning
6241640 
Signed-off-by: Blake McHale <bmchale@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bmchalenv