Fix double-free for ZSTs with Drop in .extend()#308
Merged
bluss merged 2 commits intobluss:masterfrom May 3, 2026
Merged
Conversation
Owner
|
Thanks for the perfect PR, that all looks valid. I will have time to make a release next weekend |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zero-sized types that
impl Dropget dropped twice in.extend(). This PR adds a test to demonstrate it, and fixes the issue.This is a soundness bug, but likely not a big deal in practice, since this kind of type is really uncommon.
The issue was discovered by GPT-5.5 high