vehicle-setup: allow testing all configured ArduSub motors - #4135
Draft
Daniiiil1 wants to merge 1 commit into
Draft
vehicle-setup: allow testing all configured ArduSub motors#4135Daniiiil1 wants to merge 1 commit into
Daniiiil1 wants to merge 1 commit into
Conversation
|
|
Daniiiil1
force-pushed
the
codex/allow-testing-all-ardusub-motors
branch
from
August 12, 2026 06:29
993c519 to
950d4c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
MOTOR<n>enum name instead of the numericMOTOR1..MOTOR8rangeMOTOR9..MOTOR12functionsWhy
ArduPilot assigns
MOTOR9..MOTOR12to values 82–85, outside the contiguous 33–40 range used byMOTOR1..MOTOR8. The existing numeric range check therefore hides configured motors 9–12 from the PWM motor-test UI.Matching the enum member name also avoids accidentally treating
MOTORTILTas a numbered motor and naturally supports future numbered motor functions added to the enum.Closes #4010.
Validation
bun --cwd core/frontend lintbun --cwd core/frontend buildgit diff --checkThe repository-wide pre-push hook could not run in this environment because Docker is not installed; the frontend-specific checks above passed.