Skip to content

[1.4] Backport helper service detection retries - #4133

Draft
joaoantoniocardoso wants to merge 3 commits into
bluerobotics:1.4-devfrom
joaoantoniocardoso:fix/helper-available-services-stuck-invalid
Draft

[1.4] Backport helper service detection retries#4133
joaoantoniocardoso wants to merge 3 commits into
bluerobotics:1.4-devfrom
joaoantoniocardoso:fix/helper-available-services-stuck-invalid

Conversation

@joaoantoniocardoso

@joaoantoniocardoso joaoantoniocardoso commented Aug 12, 2026

Copy link
Copy Markdown
Member

Summary

Test plan

  • Boot BlueOS 1.4 and force early helper scans before Cable Guy / Commander / Kraken / Beacon / Ping are ready
  • Confirm a failed first detect (Invalid: None - None) no longer permanently hides the service
  • Confirm the service appears in /helper/latest/web_services once healthy (without restarting helper)
  • Confirm timeout-heavy non-HTTP listeners still stop being retried after 3 timeout attempts

@github-actions

Copy link
Copy Markdown

Automated PR Review

0. Summary

  • Verdict: LGTM :shipit:

Backport for the 1.4 branch: in core/services/helper/main.py, periodic() now filters invalid entries out of Helper.KNOWN_SERVICES every 60 s so a system service that failed initial detection (e.g. wasn't ready yet at boot and burned through MAX_ATTEMPTS_LEFT) gets a fresh chance instead of being permanently skipped via the service.max_attempts_reached() short-circuit in scan_ports() (core/services/helper/main.py:410). The KEEP_BLUEOS_SERVICES_ALIVE=False branch in scan_ports() only evicts services whose TCP port stopped listening, which didn't cover this "listening but not responding correctly" case. Minimal, well-scoped fix with a comment that explains the "why".

No further comments, nice job 👍

Generated by PR Review Bot. This is advisory, a human reviewer must still approve.

@joaoantoniocardoso
joaoantoniocardoso marked this pull request as draft August 12, 2026 00:19
nicoschmdt and others added 3 commits August 11, 2026 21:20
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@joaoantoniocardoso
joaoantoniocardoso force-pushed the fix/helper-available-services-stuck-invalid branch from 344a989 to 9816a65 Compare August 12, 2026 00:21
@joaoantoniocardoso joaoantoniocardoso changed the title [1.4] Allow available services re-scan [1.4] Backport helper service detection retries Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[1.4] Helper: Available Services can permanently omit healthy BlueOS system services after boot-time probe failure

3 participants