[1.4] core: Fix nmea_injector failing to import its own package - #4128
Open
joaoantoniocardoso wants to merge 1 commit into
Open
[1.4] core: Fix nmea_injector failing to import its own package#4128joaoantoniocardoso wants to merge 1 commit into
joaoantoniocardoso wants to merge 1 commit into
Conversation
nmea_injector is the only service whose main.py imports its own package by name, and it lived inside that package. Running it directly puts the package directory itself on sys.path, so `import nmea_injector` cannot resolve and the service crash-loops on startup. This used to work because install-services.sh ran `pip3 install .` for every service, installing them as packages. The uv migration set `package = false` everywhere, which stopped that, and nmea_injector was the only service that depended on it. Moving main.py up to the service root puts the parent directory on sys.path instead, matching every other service and the layout master already uses. Rename cherry-picked from b95daa2, dropping its unrelated shebang and wifi changes.
joaoantoniocardoso
changed the title
Automated PR Review0. Summary
Moves No further comments, nice job 👍 Generated by PR Review Bot. This is advisory, a human reviewer must still approve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4127