[backport/1.4] core: Use ISO 8601 UTC timestamps for logs - #4126
Open
joaoantoniocardoso wants to merge 2 commits into
Open
[backport/1.4] core: Use ISO 8601 UTC timestamps for logs#4126joaoantoniocardoso wants to merge 2 commits into
joaoantoniocardoso wants to merge 2 commits into
Conversation
Different log formats make navigating and interpreting them confusing, and local-time stamps are ambiguous across vehicles in different timezones. Unlike master, 1.4 registers a file sink in init_logger, so the format is applied there as well. Without it the log files users download would keep the old format and only stderr would be fixed. Backport of c1e2190.
Log contents are now ISO 8601 UTC, but the filenames were still local time, so a log dump disagreed with itself about the timezone. The extended format is not filename friendly, so the basic format is used instead. Lexicographic order still matches chronological order.
joaoantoniocardoso
marked this pull request as draft
August 11, 2026 20:29
Automated PR Review0. Summary
Backports the ISO 8601 UTC log timestamp change from master (#4124 / c1e2190) into Spot-checks:
No further comments, nice job 👍 Generated by PR Review Bot. This is advisory, a human reviewer must still approve. |
joaoantoniocardoso
marked this pull request as ready for review
August 11, 2026 21:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #4124 (c1e2190) into 1.4 + log filename fix for consistency.